-
Notifications
You must be signed in to change notification settings - Fork 124
Upgrade node-version to 16 (was 14) in GitHub Actions workflows #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…top.yml and integration_tests.yml)
Integration test with FLAKINESS (succeeded after retry)Requested by @dconeybe on commit 6872ba4
Add flaky tests to go/fpl-cpp-flake-tracker |
.github/workflows/desktop.yml
Outdated
@@ -357,7 +357,7 @@ jobs: | |||
- name: Set up Node (14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Set up Node (16)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Is this incompatible with the retry PR? (I'm merging that one - I figure it's still best to retry any network-related thing if possible). |
No. They are compatible. I agree, that the retry is useful regardless of which node version is being installed. |
Upgrade
node-version
to 16 (was 14) in GitHub Actions workflows (desktop.yml
andintegration_tests.yml
).Node version 16 is the "long term support" version.
This may also fix intermittent failures of
npm install -g firebase-tools
with the error "npm ERR! cb() never called!"