Upgrade node-version to 16 (was 14) in GitHub Actions workflows #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…top.yml and integration_tests.yml)
dconeybe
added
skip-release-notes
github-actions
bot
added
tests: in-progress
Integration test with FLAKINESS (succeeded after retry)Requested by @dconeybe on commit 6872ba4
Add flaky tests to go/fpl-cpp-flake-tracker |
3 tasks
firebase-workflow-trigger
bot
removed
the
tests: in-progress
sunmou99
reviewed
Aug 30, 2022
.github/workflows/desktop.yml
Outdated
| @@ -357,7 +357,7 @@ jobs: | |||
| - name: Set up Node (14) | |||
|
Is this incompatible with the retry PR? (I'm merging that one - I figure it's still best to retry any network-related thing if possible). |
No. They are compatible. I agree, that the retry is useful regardless of which node version is being installed. |
sunmou99
approved these changes
Aug 30, 2022
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
node-versionto 16 (was 14) in GitHub Actions workflows (desktop.ymlandintegration_tests.yml).Node version 16 is the "long term support" version.
This may also fix intermittent failures of
npm install -g firebase-toolswith the error "npm ERR! cb() never called!"