Skip to content

Upgrade node-version to 16 (was 14) in GitHub Actions workflows #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

dconeybe
Copy link
Contributor

Upgrade node-version to 16 (was 14) in GitHub Actions workflows (desktop.yml and integration_tests.yml).

Node version 16 is the "long term support" version.

This may also fix intermittent failures of npm install -g firebase-tools with the error "npm ERR! cb() never called!"

@dconeybe dconeybe self-assigned this Aug 30, 2022
@dconeybe dconeybe added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Aug 30, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 30, 2022
@github-actions
Copy link

github-actions bot commented Aug 30, 2022

Integration test with FLAKINESS (succeeded after retry)

Requested by @dconeybe on commit 6872ba4
Last updated: Tue Aug 30 22:09 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
functions [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdViewLoadAdInlineAdaptiveAd
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdStress

Add flaky tests to go/fpl-cpp-flake-tracker

@dconeybe dconeybe requested a review from sunmou99 August 30, 2022 14:24
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 30, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 30, 2022
@@ -357,7 +357,7 @@ jobs:
- name: Set up Node (14)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Set up Node (16)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dconeybe dconeybe removed the tests: failed This PR's integration tests failed. label Aug 30, 2022
@dconeybe dconeybe requested a review from sunmou99 August 30, 2022 17:56
@jonsimantov
Copy link
Contributor

Is this incompatible with the retry PR? (I'm merging that one - I figure it's still best to retry any network-related thing if possible).

@dconeybe
Copy link
Contributor Author

Is this incompatible with the retry PR? (I'm merging that one - I figure it's still best to retry any network-related thing if possible).

No. They are compatible. I agree, that the retry is useful regardless of which node version is being installed.

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 30, 2022
@dconeybe dconeybe removed the tests: failed This PR's integration tests failed. label Aug 30, 2022
@dconeybe dconeybe merged commit 6872ba4 into main Aug 31, 2022
@dconeybe dconeybe deleted the dconeybe/GHANodeVersionUpgrade branch August 31, 2022 02:22
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. labels Aug 31, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 31, 2022
@firebase firebase locked and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants