Skip to content

Add retry to npm installation of firebase-tools #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Aug 22, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Installing firebase-tools requires network connectivity - thus we should retry if it fails.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Run integration tests, ensure no issues installing firebase-tools


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Aug 22, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Aug 22, 2022
@github-actions
Copy link

github-actions bot commented Aug 22, 2022

❌  Integration test FAILED

Requested by @jonsimantov on commit fa6d390
Last updated: Tue Aug 30 15:16 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: emulator_target]
firestore [TEST] [FAILURE] [tvOS] [macos] [tvos_simulator]
(1 failed tests)  CleanupTest.DocumentChangeIsBlankAfterCleanup
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 22, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 22, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Aug 24, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Aug 24, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 24, 2022
@jonsimantov jonsimantov requested a review from sunmou99 August 29, 2022 17:04
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Aug 29, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Aug 29, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 29, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 29, 2022
@dconeybe
Copy link
Contributor

FWIW, #1064 upgrades the node version from 14 to 16, which may fix the recent "npm ERR! cb() never called!" problems/flakiness with installing the Firestore emulator.

@jonsimantov jonsimantov enabled auto-merge (squash) August 30, 2022 18:05
@jonsimantov jonsimantov added skip-release-notes Skip release notes check and removed tests: failed This PR's integration tests failed. labels Aug 30, 2022
@jonsimantov jonsimantov merged commit fa6d390 into main Aug 30, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Aug 30, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 30, 2022
@firebase firebase locked and limited conversation to collaborators Sep 30, 2022
@jonsimantov jonsimantov deleted the bugfix/firebase-tools-flaky-install branch November 3, 2022 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants