Skip to content

Upgrade node-version to 16 (was 14) in GitHub Actions workflows #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Upgrade node-version to 16 (was 14) in GitHub Actions workflows #1064

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2531cd5
Upgrade node-version to 16 (was 14) in GitHub Actions workflows (desk…
dconeybe Aug 30, 2022
05c3ef7
fix the 'name' of the workflow steps to reflect the new node version
dconeybe Aug 30, 2022
8fed0d6
Merge branch 'main' into dconeybe/GHANodeVersionUpgrade
dconeybe Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ jobs:
- name: Set up Node (14)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Set up Node (16)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

uses: actions/setup-node@v2
with:
node-version: 14.x
node-version: 16.x
- name: Setup Firestore Emulator
run: |
npm install -g firebase-tools
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ jobs:
- name: Set up Node (14)
uses: actions/setup-node@v2
with:
node-version: 14.x
node-version: 16.x
- name: Setup Firestore Emulator
run: |
npm install -g firebase-tools
Expand Down Expand Up @@ -990,7 +990,7 @@ jobs:
- name: Set up Node (14)
uses: actions/setup-node@v2
with:
node-version: 14.x
node-version: 16.x
- name: Setup java 17 for Firestore emulator
uses: actions/setup-java@v3
with:
Expand Down Expand Up @@ -1125,7 +1125,7 @@ jobs:
- name: Set up Node (14)
uses: actions/setup-node@v2
with:
node-version: 14.x
node-version: 16.x
- name: Setup java for Firestore emulator
uses: actions/setup-java@v3
with:
Expand Down