Skip to content

Add retry to npm installation of firebase-tools #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Add retry to npm installation of firebase-tools #1059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ca3ef6
Add retry to npm installation of firebase-tools
jonsimantov Aug 22, 2022
af1f8f5
Merge branch 'main' into bugfix/firebase-tools-flaky-install
jonsimantov Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,12 @@ jobs:
with:
node-version: 14.x
- name: Setup Firestore Emulator
run: |
npm install -g firebase-tools
uses: nick-invision/retry@v2
with:
shell: bash
timeout_minutes: 5
max_attempts: 3
command: npm install -g firebase-tools
- name: Setup java
uses: actions/setup-java@v3
with:
Expand Down
35 changes: 30 additions & 5 deletions .github/workflows/integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,8 +739,12 @@ jobs:
with:
node-version: 14.x
- name: Setup Firestore Emulator
run: |
npm install -g firebase-tools
uses: nick-invision/retry@v2
with:
shell: bash
timeout_minutes: 5
max_attempts: 3
command: npm install -g firebase-tools
- name: Setup java
uses: actions/setup-java@v3
with:
Expand Down Expand Up @@ -997,9 +1001,16 @@ jobs:
distribution: 'temurin'
java-version: '17'
- name: Setup Firestore Emulator
if: steps.get-device-type.outputs.device_type == 'virtual' && contains(needs.check_and_prepare.outputs.apis, 'firestore')
uses: nick-invision/retry@v2
with:
shell: bash
timeout_minutes: 5
max_attempts: 3
command: npm install -g firebase-tools
- name: Start Firestore Emulator
if: steps.get-device-type.outputs.device_type == 'virtual' && contains(needs.check_and_prepare.outputs.apis, 'firestore')
run: |
npm install -g firebase-tools
firebase emulators:start --only firestore --project demo-example &
- name: Setup java 8 for test_simulator.py
uses: actions/setup-java@v3
Expand Down Expand Up @@ -1132,9 +1143,16 @@ jobs:
distribution: 'temurin'
java-version: '17'
- name: Setup Firestore Emulator
if: steps.get-device-type.outputs.device_type == 'virtual' && contains(needs.check_and_prepare.outputs.apis, 'firestore')
uses: nick-invision/retry@v2
with:
shell: bash
timeout_minutes: 5
max_attempts: 3
command: npm install -g firebase-tools
- name: Start Firestore Emulator
if: steps.get-device-type.outputs.device_type == 'virtual' && contains(needs.check_and_prepare.outputs.apis, 'firestore')
run: |
npm install -g firebase-tools
firebase emulators:start --only firestore --project demo-example &
- name: Run iOS integration tests on Simulator locally
timeout-minutes: 120
Expand Down Expand Up @@ -1241,9 +1259,16 @@ jobs:
distribution: 'temurin'
java-version: '17'
- name: Setup Firestore Emulator
if: contains(needs.check_and_prepare.outputs.apis, 'firestore')
uses: nick-invision/retry@v2
with:
shell: bash
timeout_minutes: 5
max_attempts: 3
command: npm install -g firebase-tools
- name: Start Firestore Emulator
if: contains(needs.check_and_prepare.outputs.apis, 'firestore')
run: |
npm install -g firebase-tools
firebase emulators:start --only firestore --project demo-example &
- name: Run tvOS integration tests on Simulator locally
timeout-minutes: 90
Expand Down