Adds support for Parity addReservedPeer for Management of PoA Parity Clusters #1204
Conversation
Allow programmatical management of private parity clusters. Method documentation: <https://wiki.parity.io/JSONRPC-parity_set-module#parity_addreservedpeer>
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
Looks good to me so far! Do you mind testing this?
|
I have tested it in a private Parity cluster for both a positive and negative case and can confirm that it is working. |
|
Sorry, my comment was unclear. I meant, will you please add a test (or however many tests you feel are warranted :) ) to the codebase? I think here is where it should live. Thanks! |
Exceptions generated by eth-abi are fairly descriptive. It seems a bit redundant to wrap encoding exceptions with this extra message and also filter out the original exception type.
I added the test. However, the RPC Parity backend does not have the addReservedPeer method. Is this a local parity node or mockup the tests are running against? If yes, can you point me to the file, please? |
Fix bug when checking _pm attr on w3
Remove unnecessary exception catching
Some fixes in `find_matching_fn_abi`
|
That is a good question. @pipermerriam do you know the answer^? |
Improvements to `merge_args_and_kwargs`
|
Probably need to update the version of parity we are testing against:
I won't be surprised if the parity fixtures also end up needing to be updated if parity has upgraded it's database schema (which I think it did recently) |
Add manifest and input arg validation to pm.release_package()
Store registry address as checksummed
Update vyper registry assets
|
@pipermerriam Thanks! I do not know the Web3.py CI system. Can you help me upgrading it to Parity 2.3.x stable? I think it make sense to do so as more and more users started to use Parity. A better support from web3.py would be a good thing to have. |
|
I can! Thanks @drelu! I'll wrap this one up |
Remove process type utility function
Allow programmatical management of private parity clusters. Method documentation: <https://wiki.parity.io/JSONRPC-parity_set-module#parity_addreservedpeer>
9 participants
What was wrong?
Related to Issue #1203
How was it fixed?
Added function addReservedPeer to parity module