Fix bug when checking _pm attr on w3 #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
approved these changes
Jan 22, 2019
| @property | ||
| def pm(self): | ||
| if self._pm is not None: | ||
| if hasattr(self, '_pm'): |
Member
There was a problem hiding this comment.
I think I'd be in favor of just having _pm = None defined on the class so that we don't have to do hasattr checks.
Contributor
Author
There was a problem hiding this comment.
Defining _pm = None on the class causes a conflict with the way the PM module is eventually attached when running w3.enable_unaudited_package_management_api()
Cannot set <web3.main.Web3 object at 0x1050596d8> module named '_pm'. The web3 object already has an attribute with that name
It seems as though we can either hasattr check or change the way the PM module is attached to the w3 instance - currently ...
def enable_unaudited_package_management_api(self):
PM.attach(self, '_pm')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
w3.pmwould raise a genericAttributeErrorrather than the intendedAttributeErrorwhen checking forweb3._pmif the attribute hadn't been set yet.Cute Animal Picture