Skip to content

Merge bootstrap4 sxs support from release/6.0 #37294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Merge bootstrap4 sxs support from release/6.0 #37294

wants to merge 1 commit into from

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Oct 5, 2021

Replacing #36397

@ghost ghost added the area-identity Includes: Identity and providers label Oct 5, 2021
@HaoK HaoK mentioned this pull request Oct 5, 2021
Closed
@HaoK
Copy link
Member Author

HaoK commented Oct 6, 2021 •
edited
Loading

@dougbu do you have any ideas on what I can try to resolve this weird error with this backport of a change from release/6.0? I can't reproduce this build error locally at all, I did a full git clean/nuke of artifacts, and even tried running .\build.cmd -ci but things build fine locally for me.

@dougbu
Copy link
Contributor

dougbu commented Oct 6, 2021

@dougbu do you have any ideas on what I can try to resolve this weird error with this backport of a change from release/6.0?

It appears the <GenerateStaticWebAsssetsPropsFile /> task in the 7.0.100-alpha.1.21474.3 SDK currently used for the 'main' branch is not compatible with the options you're using. We moved to the 6.0.100-rtm.21477.15 SDK in the 'release/6.0' branch just one day after the most recent SDK change in 'main'. So, this is indeed a bit strange.

Thoughts @javiercn❔ You made the last few changes to this task. Does @HaoK just need to wait for #37192 to bring us to the 7.0.100-alpha.1.21480.20 SDK❔

@HaoK
Copy link
Member Author

HaoK commented Oct 6, 2021

Yeah I don't understand why I can't reproduce this locally either...

@HaoK
Copy link
Member Author

HaoK commented Dec 7, 2021

Replaced by #38865

@HaoK HaoK closed this Dec 7, 2021
@HaoK HaoK deleted the haok/boot5mg branch January 27, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoK @dougbu