Port of Bootstrap v4 SxS support to 7.0 #38865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
* Add props and build files * Bring back V4 files tmp Setup V5 stuff * Add back v5 files too Restore V4 files Undo diffs Update Testing.DefaultWebSite.StaticWebAssets.V5.xml Fix tests Checkpoint Fix Undo Try bootstrap4 codepath Stuff Checkpoint before rebase * Correct target names * Fix views * Cleanup * Fix test * Bring back targets * Make things work * PR feedback * Fix for content type * Harden the view version logic * Fix test * Nullable warning fixes * Fix nullable warning another way * Fix V4 nullability warnings * Another nullability fix * Fix CI Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Hao Kung <[email protected]>
|
Was this already reviewed in 6.0? |
|
Yep, this is just a port forward, so there's nothing new to review |
wtgodbe
approved these changes
Jan 5, 2022
|
I told AzDO to rerun the failed jobs because we have some evidence the agent acquisition problem has cleared up. Separately, why was this work done first in release/6.0❔ I see things started in 'main' but further work was done for 6.0 instead of there. |
|
There was SDK changes that were only in release/6.0 which this work depended on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of 77d5fbb