-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[main] [release/6.0] Initial Bootstrap v4 SxS support #36397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
tmp Setup V5 stuff
Restore V4 files Undo diffs Update Testing.DefaultWebSite.StaticWebAssets.V5.xml Fix tests Checkpoint Fix Undo Try bootstrap4 codepath Stuff Checkpoint before rebase
053d683
to
b971d3f
Compare
@javiercn I'm having trouble backporting the rc2 identity changes to 7.0, are there differences in the tasks/sdk that need to be accounted for?
|
@@ -36,5 +63,96 @@ public static IdentityBuilder AddDefaultUI(this IdentityBuilder builder) | |||
|
|||
return builder; | |||
} | |||
|
|||
private static Assembly GetApplicationAssembly(IdentityBuilder builder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @captainsafia @halter73 this is the other piece of code in the framework that does a bad thing 😄
|
||
private static Assembly GetApplicationAssembly(IdentityBuilder builder) | ||
{ | ||
// This is the same logic that MVC follows to find the application assembly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaoK Can you link to the existing logic? Having trouble finding it by copy/pasting the source here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its in release/6.0 only right now, as I'm unable to port this to main so far https://github.com/dotnet/aspnetcore/blob/release/6.0/src/Identity/UI/src/IdentityBuilderUIExtensions.cs#L67
@HaoK SDK mismatch? |
replaced by #37294 |
Backport of #36378 to main
/cc @HaoK @github-actions[bot]
Customer Impact
Testing
Risk