Skip to content

[main] [release/6.0] Initial Bootstrap v4 SxS support #36397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #36378 to main

/cc @HaoK @github-actions[bot]

Customer Impact

Testing

Risk

@github-actions github-actions bot requested a review from Pilchie as a code owner September 11, 2021 01:14
@ghost ghost added the area-identity Includes: Identity and providers label Sep 11, 2021
@HaoK HaoK self-assigned this Sep 11, 2021
@HaoK
Copy link
Member

HaoK commented Sep 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@HaoK HaoK force-pushed the backport/pr-36378-to-main branch from 053d683 to b971d3f Compare September 30, 2021 21:25
@HaoK
Copy link
Member

HaoK commented Sep 30, 2021

@javiercn I'm having trouble backporting the rc2 identity changes to 7.0, are there differences in the tasks/sdk that need to be accounted for?

src\Identity\UI\src\Microsoft.AspNetCore.Identity.UI.csproj(96,70): error MSB4064: (NETCORE_ENGINEERING_TELEMETRY=Build) The "PackagePathPrefix" parameter is not supported by the "GenerateStaticWebAsssetsPropsFile" task loaded from assembly: Microsoft.NET.Sdk.Razor.Tasks, Version=7.0.4.43032, Culture=neutral, PublicKeyToken=31bf3856ad364e35 from the path: D:\a\_work\1\s\.dotnet\sdk\7.0.100-alpha.1.21474.3\Sdks\Microsoft.NET.Sdk.Razor\tasks\net6.0\Microsoft.NET.Sdk.Razor.Tasks.dll. Verify that the parameter exists on the task, the <UsingTask> points to the correct assembly, and it is a settable public instance property.

@BrennanConroy BrennanConroy mentioned this pull request Oct 3, 2021
4 tasks
@@ -36,5 +63,96 @@ public static IdentityBuilder AddDefaultUI(this IdentityBuilder builder)

return builder;
}

private static Assembly GetApplicationAssembly(IdentityBuilder builder)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @captainsafia @halter73 this is the other piece of code in the framework that does a bad thing 😄


private static Assembly GetApplicationAssembly(IdentityBuilder builder)
{
// This is the same logic that MVC follows to find the application assembly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaoK Can you link to the existing logic? Having trouble finding it by copy/pasting the source here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its in release/6.0 only right now, as I'm unable to port this to main so far https://github.com/dotnet/aspnetcore/blob/release/6.0/src/Identity/UI/src/IdentityBuilderUIExtensions.cs#L67

@javiercn
Copy link
Member

javiercn commented Oct 4, 2021

@HaoK SDK mismatch?

@HaoK
Copy link
Member

HaoK commented Oct 5, 2021

replaced by #37294

@HaoK HaoK closed this Oct 5, 2021
@BrennanConroy BrennanConroy deleted the backport/pr-36378-to-main branch October 7, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants