[main] [release/6.0] Initial Bootstrap v4 SxS support #36397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
tmp Setup V5 stuff
Restore V4 files Undo diffs Update Testing.DefaultWebSite.StaticWebAssets.V5.xml Fix tests Checkpoint Fix Undo Try bootstrap4 codepath Stuff Checkpoint before rebase
HaoK
force-pushed
the
backport/pr-36378-to-main
branch
from
053d683 to
b971d3f
Compare
|
@javiercn I'm having trouble backporting the rc2 identity changes to 7.0, are there differences in the tasks/sdk that need to be accounted for? |
4 tasks
davidfowl
reviewed
Oct 3, 2021
| @@ -36,5 +63,96 @@ public static IdentityBuilder AddDefaultUI(this IdentityBuilder builder) | |||
|
|
|||
| return builder; | |||
| } | |||
|
|
|||
| private static Assembly GetApplicationAssembly(IdentityBuilder builder) | |||
There was a problem hiding this comment.
cc @captainsafia @halter73 this is the other piece of code in the framework that does a bad thing 😄
captainsafia
reviewed
Oct 4, 2021
|
|
||
| private static Assembly GetApplicationAssembly(IdentityBuilder builder) | ||
| { | ||
| // This is the same logic that MVC follows to find the application assembly. |
There was a problem hiding this comment.
@HaoK Can you link to the existing logic? Having trouble finding it by copy/pasting the source here.
There was a problem hiding this comment.
Its in release/6.0 only right now, as I'm unable to port this to main so far https://github.com/dotnet/aspnetcore/blob/release/6.0/src/Identity/UI/src/IdentityBuilderUIExtensions.cs#L67
|
@HaoK SDK mismatch? |
|
replaced by #37294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36378 to main
/cc @HaoK @github-actions[bot]
Customer Impact
Testing
Risk