Disable ref overloads for opaque pointer types #1341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beyley
force-pushed
the
feature/no-ref-for-opaque-pointers
branch
2 times, most recently
from
0401f15 to
204676c
Compare
Contributor
Author
|
Relies on #1349 |
Beyley
force-pushed
the
feature/no-ref-for-opaque-pointers
branch
5 times, most recently
from
dee0dbb to
6acfd7e
Compare
Contributor
Author
|
if CI passes then HOPEFULLY this should be ready for merge, as this also fixes OpenXR generation, so lets get it in before 2.17 |
Beyley
force-pushed
the
feature/no-ref-for-opaque-pointers
branch
4 times, most recently
from
e27a726 to
0c8ffed
Compare
Member
|
Your git history still a little wonky, I'll try my best to fix it but some of the commit messages may get lost. This is why I hate force push! |
Perksey
force-pushed
the
feature/no-ref-for-opaque-pointers
branch
from
add497c to
0a20df9
Compare
Perksey
requested changes
Apr 1, 2023
Member
Perksey
left a comment
Perksey
left a comment
There was a problem hiding this comment.
Reviewed what I could but after a while the iPad just stopped rendering files. I think this covers most of it though.
Some comments could in theory be saved for later but I would like to get the questions around the D2D1/DirectWrite/WIC division sorted about before we release (because we can't change our minds once it's shipped)
src/Core/Silk.NET.BuildTools/Overloading/Simple/RefOverloader.cs
Outdated
Show resolved
Hide resolved
src/Microsoft/Silk.NET.Direct2D/Structs/D2D1BitmapRenderTargetVtblExtensions.gen.cs
Show resolved
Hide resolved
src/Microsoft/Silk.NET.Direct2D/Structs/D2D1CommandSink1VtblExtensions.gen.cs
Show resolved
Hide resolved
src/Microsoft/Silk.NET.Direct2D/Structs/D2D1Device2VtblExtensions.gen.cs
Show resolved
Hide resolved
src/Microsoft/Silk.NET.Direct2D/Structs/D2D1DeviceContext3VtblExtensions.gen.cs
Show resolved
Hide resolved
Beyley
force-pushed
the
feature/no-ref-for-opaque-pointers
branch
from
fa5ccb4 to
f8c5eb2
Compare
This makes generation exceptions print as red, and the final job summary print succeeded jobs as green, and failed jobs as red, providing much more visual clarity
Beyley
force-pushed
the
feature/no-ref-for-opaque-pointers
branch
2 times, most recently
from
ba500b3 to
ce94205
Compare
This re-adds the missing ref overloads for functions like EnableTraceEx
This can happen when something has 2 ComBases that were typemapped to IUnknown
Beyley
force-pushed
the
feature/no-ref-for-opaque-pointers
branch
from
ce94205 to
512143a
Compare
Contributor
Author
|
Freedesktop gitlab seems down, we may have to delay until their site comes back up as DXVK submodules something from there and we fail during cloning in CI |
3 tasks
Perksey
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
While these overloads were usable, they were extremely error prone and should not be used, this cleans up the amount of overloads, and blocks very error prone code from being written
Related issues, Discord discussions, or proposals
https://discord.com/channels/521092042781229087/587346162802229298/1087098494562603108