Add unit test timeout #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
added
enhancement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 98.52% 98.52% -0.01%
==========================================
Files 2 2
Lines 543 541 -2
==========================================
- Hits 535 533 -2
Misses 8 8
☔ View full report in Codecov by Sentry. |
dbutenhof
previously approved these changes
Aug 30, 2023
webbnh
dismissed
dbutenhof’s stale review
The merge-base changed after approval.
webbnh
force-pushed
the
unittest-timeout
branch
from
50cf9fa to
95fc058
Compare
dbutenhof
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timeouts to prevent unit tests from hanging.
This was originally part of #7, but it doesn't really have anything to do with that change; and, since I had to rebase it on top of #8 anyway, I figured I would split it out into it's own PR. Note that, until #8 is merged, its commit(s) will show up here; so, for this review, only the last commit (so far) should be considered.