Skip to content

Conversation

@webbnh
Copy link
Member

@webbnh webbnh commented Aug 30, 2023

This PR removes the "prompt" requirement from the --bind option configuration, so that, if the option is omitted from the command line, the default value will be silently used, rather than requiring the user to confirm it.

This was originally part of #7, but, while it is important for the effectiveness of that change, it doesn't really have anything to do containerization; and, since I had to rebase it on top of #8 anyway, I figured I would split it out into it's own PR. Note that this PR is layered on top of #9, so until it is merged, its commit(s) (and those of #8) will show up here; so, for this review, only the last commit (so far) should be considered.

@webbnh webbnh added the enhancement New feature or request label Aug 30, 2023
@webbnh webbnh requested a review from dbutenhof August 30, 2023 16:56
@webbnh webbnh self-assigned this Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9655b23) 98.52% compared to head (19f7c6a) 98.52%.

❗ Current head 19f7c6a differs from pull request most recent head 82ad46a. Consider uploading reports for the commit 82ad46a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files           2        2           
  Lines         541      541           
=======================================
  Hits          533      533           
  Misses          8        8           
Files Changed Coverage Δ
src/relay/relay.py 100.00% <100.00%> (ø)
tests/test_relay.py 97.95% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webbnh webbnh mentioned this pull request Aug 30, 2023
@webbnh webbnh changed the title Bind option optional Make the --bind option optional Aug 30, 2023
dbutenhof
dbutenhof previously approved these changes Aug 30, 2023
@webbnh webbnh dismissed dbutenhof’s stale review August 30, 2023 18:46

The merge-base changed after approval.

@webbnh webbnh force-pushed the bind-option-optional branch from 19f7c6a to 82ad46a Compare August 30, 2023 18:46
@webbnh webbnh requested a review from dbutenhof August 30, 2023 18:46
@webbnh webbnh merged commit b4784f8 into distributed-system-analysis:main Aug 30, 2023
@webbnh webbnh deleted the bind-option-optional branch August 30, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants