Skip to content

Conversation

@webbnh
Copy link
Member

@webbnh webbnh commented Aug 29, 2023

This PR adds the capability to build and publish the file-relay utility as a container image.

This change provides a Dockerfile which builds a container image that executes the file-relay utility as its entry point. The resulting container can be invoked as though it were the file-relay utility, with file-relay command options specified at the end of the invocation command line.

This change also provides a .dockerignore file and a GitHub Actions workflow which causes the container image to built when a commit is pushed to a release/** branch, when a tag is created or updated, or when a GitHub release is created or updated. On successful build, the container image is exported to Quay.io and tagged with the branch name, Git tag, or release tag, as appropriate.

Note that this PR is based on #10, so the commits from that PR and its precursors will show up here until they are merged.

PBENCH-1258

@webbnh webbnh added documentation Improvements or additions to documentation enhancement New feature or request infrastructure CI, build, test harness, configuration, etc. labels Aug 29, 2023
@webbnh webbnh requested a review from dbutenhof August 29, 2023 19:07
@webbnh webbnh self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b4784f8) 98.52% compared to head (2d0654d) 98.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files           2        2           
  Lines         541      541           
=======================================
  Hits          533      533           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbutenhof
dbutenhof previously approved these changes Aug 29, 2023
@webbnh webbnh marked this pull request as draft August 29, 2023 22:04
@webbnh
Copy link
Member Author

webbnh commented Aug 29, 2023

Converting this PR to a draft while I rebase it on #8.

@dbutenhof
Copy link
Member

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (74ae60d) 98.52% compared to head (848a679) 98.52%.

Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

This is really cool... Pbench is feeling envious ...

@webbnh
Copy link
Member Author

webbnh commented Aug 30, 2023

This is really cool... Pbench is feeling envious ...

Yeah, but Pbench has way more code and already has a solution (although...well...it could be made better).

Seriously, though, I think I had a reason for not proposing this solution for Pbench, although I don't recall now what it was. 😵

This was referenced Aug 30, 2023
@webbnh webbnh marked this pull request as ready for review August 30, 2023 17:01
@webbnh webbnh marked this pull request as draft August 30, 2023 17:02
@webbnh webbnh force-pushed the containerization branch 3 times, most recently from 04f6c22 to dcdac7e Compare August 30, 2023 17:45
@webbnh webbnh marked this pull request as ready for review August 30, 2023 18:00
@webbnh
Copy link
Member Author

webbnh commented Aug 30, 2023

OK, I think this is now, once again, actually, ready for review (I've left the penultimate commit unchanged and added updates in the commit that follows it for the change in the directory structure from #8, the removal of the PYTHONPATH definition, removal of the package sources now that the installation does the right thing, and some other modest tweaks).

@webbnh webbnh requested a review from dbutenhof August 30, 2023 18:04
@webbnh webbnh merged commit c6492c6 into distributed-system-analysis:main Aug 30, 2023
@webbnh webbnh deleted the containerization branch August 30, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request infrastructure CI, build, test harness, configuration, etc.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants