Skip to content

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Jun 1, 2022

See: #1632

@elliette elliette requested a review from annagrin June 1, 2022 21:59
@elliette elliette requested a review from bkonyi June 1, 2022 22:07
@override
Future<UriList> lookupResolvedPackageUris(
String isolateId, List<String> uris) async {
Future<UriList> lookupResolvedPackageUris(String isolateId, List<String> uris,
Copy link
Contributor

@annagrin annagrin Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update vm_service version to match? We need to require at least the minimum version that contains this new API or webdev users can end up using older vm_service without the parameter...

Copy link
Contributor

@annagrin annagrin Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkonyi I found this PR in dart SDK introducing the change but it does not update the vm_service package version - am I right that we need to add a constraint to this PR to depend on that min version to prevent webdev users from pulling new dwds with old vm_service?

dart-lang/sdk@d6665ae#diff-60648d19c0fe66d08d01fb7a449378bb80241a95601fe86b3d34962586abb886

Copy link
Contributor

@annagrin annagrin Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkonyi if you would like to update the vm_service version later I think it is ok but we cannot publish dwds until that happens and we add the constraint. @elliette still can submit this PR I think, and both vm_service and dwds would be unpublished versions in g3 until then. I hope that I am not wrong:)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkonyi addition - I believe it should be a major version update for vm_service for this all to work out.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this patched in g3 first and then I'll do a major release. Unfortunately, a lot of downstream dependencies need to be updated and released with new versions first.

@override
Future<UriList> lookupResolvedPackageUris(
String isolateId, List<String> uris) async {
Future<UriList> lookupResolvedPackageUris(String isolateId, List<String> uris,
Copy link
Contributor

@annagrin annagrin Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkonyi I found this PR in dart SDK introducing the change but it does not update the vm_service package version - am I right that we need to add a constraint to this PR to depend on that min version to prevent webdev users from pulling new dwds with old vm_service?

dart-lang/sdk@d6665ae#diff-60648d19c0fe66d08d01fb7a449378bb80241a95601fe86b3d34962586abb886

@annagrin annagrin self-requested a review June 1, 2022 23:19
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if we confirm that checking this in and not publishing until vm_service version update and adding the constraint is ok.)

@bkonyi
Copy link
Collaborator

bkonyi commented Jun 2, 2022

Yeah, we'll need to publish package:vm_service 9.0.0 (I can't believe we're hitting double digits on the major revision already...).

Copy link
Collaborator

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we can't publish yet. Maybe we should hold off landing this until we're ready to publish.

@override
Future<UriList> lookupResolvedPackageUris(
String isolateId, List<String> uris) async {
Future<UriList> lookupResolvedPackageUris(String isolateId, List<String> uris,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this patched in g3 first and then I'll do a major release. Unfortunately, a lot of downstream dependencies need to be updated and released with new versions first.

@elliette
Copy link
Contributor Author

elliette commented Jun 2, 2022

Update on this: we're going to hold off on submitting it until the package:vm_service version 9.0.0 has been released. Then will update the VM service min constraint and submit, followed by publishing DWDS and Webdev.

@elliette elliette merged commit b0a4059 into dart-lang:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants