Skip to content

Prep Webdev 2.7.10 release #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

elliette
Copy link
Contributor

Work towards #1632

In #1633, we updated the vm_service version required by DWDS. Before releasing DWDS, we should release Webdev with a pin on the older version of DWDS. Otherwise, the moment we release DWDS, Webdev users will get the following error:

Because every version of dwds at {{new version}} depends on vm_service ^9.0.0 and webdev depends on vm_service ^8.3.0, dwds at {{new version}} is forbidden.
So, because webdev depends on dwds at {{new version}, version solving failed.

@elliette elliette requested a review from annagrin June 28, 2022 18:08
@annagrin annagrin self-requested a review June 28, 2022 21:29
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 52068aa into dart-lang:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants