Improve scoping interaction with canonicalization, inheritance, and reexports #2699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Jun 22, 2021
lib/src/model/container_member.dart
Outdated
| Iterable<Library> get referenceGrandparentOverrides sync* { | ||
| // TODO(jcollins-g): split Field documentation up between accessors | ||
| // and resolve the pieces with different scopes. dart-lang/dartdoc#2693. | ||
| //assert(documentationFrom.length == 1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of related changes around handling inheritance and export namespaces to make the new lookup code conform more to what the old code used to do. A number of bugs are referenced, including #2698, #2696, and #2693 as we're now treating these quirks of the old code as bugs, but trying to remain compatible for now.