Skip to content

require fully specified comment references rather than allowing partial lookups via canonicalization #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcollins-g opened this issue Jun 21, 2021 · 1 comment
Closed

require fully specified comment references rather than allowing partial lookups via canonicalization #2696

jcollins-g opened this issue Jun 21, 2021 · 1 comment
Labels
P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@jcollins-g
Copy link
Contributor

The old lookup code will permit users to write expressions that can only be evaluated in the context of the dartdoc-canonical libraries in which they are documented, which may have a synthetic namespace constructed via reexports. This is not a good idea for implementing support for resolution in software besides dartdoc.
@jcollins-g jcollins-g added P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable labels Jun 21, 2021
@jcollins-g jcollins-g mentioned this issue Jun 22, 2021
Merged
@srawlins
Copy link
Member

Closing this in favor of just removing the reference lookup system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srawlins @jcollins-g