Skip to content

do not "inherit" static methods/constructors for comment references #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcollins-g opened this issue Jun 22, 2021 · 1 comment
Closed

do not "inherit" static methods/constructors for comment references #2698

jcollins-g opened this issue Jun 22, 2021 · 1 comment
Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented Jun 22, 2021 •
edited
Loading

The old lookup code accidentally allowed for inheritance of static methods/fields and let them be directly referred to in comment references. The new version, to be compatible, will do so as well for now. Remove this support and migrate critical users.
@jcollins-g jcollins-g added P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable labels Jun 22, 2021
@jcollins-g jcollins-g changed the title do not "inherit" static methods for comment references do not "inherit" static methods/constructors for comment references Jun 22, 2021
@jcollins-g jcollins-g mentioned this issue Jun 22, 2021
Merged
@srawlins
Copy link
Member

Closing in favor of just removing the comment reference lookup system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srawlins @jcollins-g