Skip to content

resolve getter/setter references with different scopes before combining docs #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jcollins-g opened this issue Jun 21, 2021 · 0 comments
Open

resolve getter/setter references with different scopes before combining docs #2693

jcollins-g opened this issue Jun 21, 2021 · 0 comments
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@jcollins-g
Copy link
Contributor

The new lookup code is going to skip over this problem much as the old one does, but it is still an issue. WRT comment reference resolution, each accessor in a GetterSetterCombo potentially has a different resolution grandparent (definingLibrary). This means that comment references in each piece of a Field or TopLevelVariable should be resolved with that context in mind. Currently the docs just get squished together meaning one accessor or the other could resolve with the wrong scope.
@jcollins-g jcollins-g added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P2 A bug or feature request we're likely to work on labels Jun 21, 2021
@jcollins-g jcollins-g changed the title resolve getter/setter references with different scopes before combining resolve getter/setter references with different scopes before combining docs Jun 21, 2021
@jcollins-g jcollins-g added the type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable label Jun 22, 2021
This was referenced Jun 22, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcollins-g