Skip to content

[android] Fix crash caused by JNIEnv null pointer in getStringUTFCharsJNI function #19079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2018
Merged

[android] Fix crash caused by JNIEnv null pointer in getStringUTFCharsJNI function #19079

merged 1 commit into from
Sep 29, 2018

Conversation

EricDDK
Copy link
Contributor

@EricDDK EricDDK commented Sep 28, 2018

tmp_crash_android_getstring

@EricDDK
Copy link
Contributor Author

EricDDK commented Sep 28, 2018

The probability of crash on the model in the figure(lenovo ipad) is 100 percent.

@drelaptop
Copy link
Contributor

did you reproduce this crash locally?

I think the game have been out-of-work when the JNIEnv equals nullptr, even with your crash fixed.

@EricDDK
Copy link
Contributor Author

EricDDK commented Sep 29, 2018 •
edited
Loading

did you reproduce this crash locally?

I think the game have been out-of-work when the JNIEnv equals nullptr, even with your crash fixed.

No,this crash only occurs on some special models, the probability is 100%, after the bug is fixed, the game is running normally. I tested it locally, Lenovo's Yoga model, Android 5.0.

I guess Lenovo's tablet Android system has experienced some secondary developments that are not in place.

drelaptop
drelaptop approved these changes Sep 29, 2018
View reviewed changes
Copy link
Contributor

@drelaptop drelaptop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add nullptr check to make more stable

@drelaptop drelaptop merged commit ebc3204 into cocos2d:v3 Sep 29, 2018
@drelaptop drelaptop added this to the 3.18 milestone Sep 29, 2018
stevetranby added a commit to stevetranby/cocos2d-x that referenced this pull request Oct 1, 2018
@stevetranby
Merge commit 'a59519a4ef567df7aabac77646d49baa4709ff01' into scgamex-…
afa83da 
…v3-merging

* commit 'a59519a4ef567df7aabac77646d49baa4709ff01': (65 commits)
  [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#19082)
  Fix several bugs with button's title (cocos2d#19073)
  [android] fix crash when point JNIEnv is a nullptr in getStringUTFCharsJNI func. (cocos2d#19079)
  [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#19074)
  refactor cmake on use libs (cocos2d#19054)
  [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#19068)
  [linux] CCFileUtils::isFileExistInternal should reject a folder (cocos2d#19062)
  Correct last delta time (cocos2d#18898)
  Add missing <functional> header which the standard requires and will be necessary to use std::function in VS2019. (cocos2d#18989)
  fix wrong parameter (cocos2d#19060)
  DrawNode add isolate flag (cocos2d#19056)
  Android: CCFileUtils listFiles impl (cocos2d#19044)
  CameraBackgroundDepthBrush should handle opengl recreate event. (cocos2d#19037)
  [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#19052)
  shorten the android build path, reduce long path error (cocos2d#19045)
  CCFileUtils: improve thread safety (use single recursive_mutex) (cocos2d#19046)
  remove assert (cocos2d#19047)
  [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#19048)
  Android: Adds supporting edge screens (cocos2d#19043)
  cocos2d::Data: prevent use after free. (cocos2d#19034)
  ...

# Conflicts:
#	build/cocos2d_libs.xcodeproj/project.pbxproj
#	cocos/3d/Android.mk
#	cocos/Android.mk
#	cocos/deprecated/CCDeprecated.h
#	cocos/editor-support/cocostudio/Android.mk
#	cocos/editor-support/spine/Android.mk
#	cocos/platform/android/libcocos2dx-with-controller/build.gradle
#	cocos/platform/android/libcocos2dx/build.gradle
#	cocos/ui/UIAbstractCheckButton.cpp
#	cocos/ui/UIButton.cpp
#	cocos/ui/UIEditBox/UIEditBox.h
#	cocos/ui/UIEditBox/UIEditBoxImpl-common.h
#	extensions/Android.mk
#	tests/cpp-tests/Classes/NewAudioEngineTest/NewAudioEngineTest.cpp
#	tests/cpp-tests/Classes/NewAudioEngineTest/NewAudioEngineTest.h
huangwei1024 pushed a commit to huangwei1024/cocos2d-x that referenced this pull request Jun 20, 2019
@EricDDK @huangwei1024
[android] fix crash when point JNIEnv is a nullptr in getStringUTFCha…
bcca022 
…rsJNI func. (cocos2d#19079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@drelaptop drelaptop drelaptop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform:android

Projects

None yet

Milestone

3.17.1

Development

Successfully merging this pull request may close these issues.

2 participants

@EricDDK @drelaptop