Skip to content

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Sep 17, 2021

closes #170 closes #58 closes #128

image

@sgratzl sgratzl self-assigned this Sep 17, 2021
@sgratzl sgratzl added the chore label Sep 17, 2021
@sgratzl sgratzl marked this pull request as ready for review September 18, 2021 20:27
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile change seems suspicious; everything else is minor.

We should make sure to deploy this to staging for more rigorous prodding before releasing in production.

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl
Copy link
Member Author

sgratzl commented Sep 24, 2021

@krivard up to you guys when you wanna merge this. Once merged it is a big change from a style and also repo structure point of view

@krivard
Copy link
Contributor

krivard commented Sep 24, 2021

@nmdefries let's merge and deploy this early next week?

@nmdefries
Copy link
Collaborator

I was planning to merge into dev today so we have some time to test in staging, then merge to main next week sounds good.

@nmdefries nmdefries merged commit f9840ed into dev Sep 24, 2021
@nmdefries nmdefries deleted the sgratzl/style_refactor branch September 24, 2021 19:17
@nmdefries
Copy link
Collaborator

The image build is failing on "Build Image" COPY dist/*.rds ./ (workflow output).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants