-
Notifications
You must be signed in to change notification settings - Fork 3
apply rshiny-template to repo #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Makefile change seems suspicious; everything else is minor.
We should make sure to deploy this to staging for more rigorous prodding before releasing in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@krivard up to you guys when you wanna merge this. Once merged it is a big change from a style and also repo structure point of view |
@nmdefries let's merge and deploy this early next week? |
I was planning to merge into dev today so we have some time to test in staging, then merge to main next week sounds good. |
The image build is failing on "Build Image" |
closes #170 closes #58 closes #128