stricter checking of types #131

igalic · 2017-09-24T15:43:26Z

This patchset addresses #39.

we've now added the entire (default) config of flake8-mypy.
The following options deviate from their default (which gets us a step
closer to mypy --strct)

ignore_missing_imports=False
follow_imports=True
cache_dir=.mypy_cache
disallow_untyped_calls=True
warn_return_any=True

We've also toggled these two:

warn_redundant_casts=True
warn_unused_ignores=True

Finally, we check for

check_untyped_defs=True

For the full --strict set, we'd also need:

disallow_untyped_defs=True

But that, we'll need better typedefs.

the consequence of this is that we need to declare the non-existent function destroy in `Resource`. As a consequence, we have to explicitly declare it in the slightly specialized classes that directly inherit from it, `DefaultResource` and `ListableResource`. We "implement" it by raising an error. This patch fixes #156, and has been once again discovered by `mypy --strict` (#131).

igalic · 2017-10-05T10:16:06Z

issues (in mypy) discovered:

__import__ is incorectly typed for python 3.6. python/mypy#4060 (this is already "solved")
mypy incorrectly infers the type of a variable from different branches python/mypy#4061 (this has a solution that doesn't work)

possible candidates:

Ask for an explicit annotation if the inferred type is None python/mypy#3741

for errors such as:

iocage/cli/destroy.py:44: error: Incompatible types in assignment (expression has type None, variable has type "Terms")

in a function definition like:

def cli(ctx,
        force: bool=False,
        release: bool=False,
        recursive: bool=False,
        download: bool=False,
        filters: iocage.lib.Filter.Terms=None) -> None:

filters will incorrectly be recognized as Terms, rather than Optional[Terms]

gronke · 2017-10-05T10:22:52Z

filters will incorrectly be recognized as Terms, rather than Optional[Terms]

Don't you have to specify that? Like such

def cli(ctx,
        force: bool=False,
        release: bool=False,
        recursive: bool=False,
        download: bool=False,
        filters: typing.Optional[iocage.lib.Filter.Terms]=None) -> None:

igalic · 2017-10-05T10:49:26Z

yup, according to the Python Zen, explicit is better than implicit. As such, mypy will be removing implicit Optional (thru None assignment) and --strict) already enforces that.

igalic

some questions

igalic · 2017-10-21T18:50:13Z

iocage/cli/__init__.py

@@ -142,6 +144,7 @@ def get_command(self, ctx, name):
                pass
            return mod.cli
        except (ImportError, AttributeError):
+            raise
            return


I need to add a --develop flag or something similar. This swallows code errors, which is okay for runtime, but hell for development. This is why it always re-appears here until I rebase a branch for merging.

igalic · 2017-10-21T18:53:59Z

iocage/cli/stop.py

@@ -75,3 +100,59 @@ def cli(ctx, rc, log_level, force, jails):
        jails_input = " ".join(list(jails))
        logger.error(f"No jails matched your input: {jails_input}")
        exit(1)
+
+
+def normal(


what's normal anyway?

not autostart

igalic · 2017-10-21T18:57:33Z

iocage/lib/Config/Jail/Defaults.py

@@ -118,7 +118,7 @@ class JailConfigDefaults(iocage.lib.Config.Jail.BaseConfig.BaseConfig):

    def __init__(
        self,
-        logger: 'iocage.lib.Logger.Logger'=None
+        logger: typing.Optional['iocage.lib.Logger.Logger']=None
