Resource is an abstract class, be clear about it #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the consequence of this is that we need to declare the non-existent function destroy in `Resource`. As a consequence, we have to explicitly declare it in the slightly specialized classes that directly inherit from it, `DefaultResource` and `ListableResource`. We "implement" it by raising an error. This patch fixes #156, and has been once again discovered by `mypy --strict` (#131).
gronke
approved these changes
Oct 3, 2017
igalic
added a commit
that referenced
this pull request
Oct 5, 2017
This is an addendum to #157 (Resource is an abstract class, be clear about it)
igalic
added a commit
that referenced
this pull request
Oct 5, 2017
This is an addendum to #157 (Resource is an abstract class, be clear about it)
igalic
added a commit
that referenced
this pull request
Oct 5, 2017
This patch is an addendum to #157 (Resource is an abstract class, be clear about it)
igalic
added a commit
that referenced
this pull request
Oct 6, 2017
This is an addendum to #157 (Resource is an abstract class, be clear about it)
igalic
added a commit
that referenced
this pull request
Oct 6, 2017
This patch is an addendum to #157 (Resource is an abstract class, be clear about it)
gronke
pushed a commit
that referenced
this pull request
Oct 8, 2017
This is an addendum to #157 (Resource is an abstract class, be clear about it)
gronke
pushed a commit
that referenced
this pull request
Oct 8, 2017
This patch is an addendum to #157 (Resource is an abstract class, be clear about it)
gronke
pushed a commit
that referenced
this pull request
Oct 8, 2017
This is an addendum to #157 (Resource is an abstract class, be clear about it)
gronke
pushed a commit
that referenced
this pull request
Oct 8, 2017
This patch is an addendum to #157 (Resource is an abstract class, be clear about it)
igalic
added a commit
that referenced
this pull request
Oct 11, 2017
This is an addendum to #157 (Resource is an abstract class, be clear about it)
igalic
added a commit
that referenced
this pull request
Oct 11, 2017
This patch is an addendum to #157 (Resource is an abstract class, be clear about it)
gronke
pushed a commit
that referenced
this pull request
Oct 21, 2017
This is an addendum to #157 (Resource is an abstract class, be clear about it)
gronke
pushed a commit
that referenced
this pull request
Oct 21, 2017
This patch is an addendum to #157 (Resource is an abstract class, be clear about it)
igalic
added a commit
that referenced
this pull request
Oct 21, 2017
This is an addendum to #157 (Resource is an abstract class, be clear about it)
igalic
added a commit
that referenced
this pull request
Oct 21, 2017
This patch is an addendum to #157 (Resource is an abstract class, be clear about it)
gronke
pushed a commit
that referenced
this pull request
Oct 21, 2017
This is an addendum to #157 (Resource is an abstract class, be clear about it)
gronke
pushed a commit
that referenced
this pull request
Oct 21, 2017
This patch is an addendum to #157 (Resource is an abstract class, be clear about it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the consequence of this is that we need to declare the non-existent
function destroy in
Resource.As a consequence, we have to explicitly declare it in the slightly
specialized classes that directly inherit from it,
DefaultResourceand
ListableResource. We "implement" it by raising an error.This patch fixes #156, and has been once again discovered by
mypy --strict(#131).