Skip to content

Resource(s) _create_resource_instance should be made abstract #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
igalic opened this issue Oct 5, 2017 · 1 comment
Closed

Resource(s) _create_resource_instance should be made abstract #162

igalic opened this issue Oct 5, 2017 · 1 comment

Comments

@igalic
Copy link
Collaborator

igalic commented Oct 5, 2017

Thanks to #131, we've discovered #161

Related to this issue: We should make Resource(s)' abstract methods actually abstract.

This should aid our type-checker in finding issues much easier, and help us in designing our classes / types correctly.

@gronke
Copy link
Member

gronke commented Aug 9, 2018

Already done 😄

@gronke gronke closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants