mypy --strict #181
Closed
mypy --strict #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patchset addresses #39. we've now added the entire (default) config of flake8-mypy. The following options deviate from their default (which gets us a step closer to mypy --strct) - ignore_missing_imports=False - follow_imports=True - cache_dir=.mypy_cache - disallow_untyped_calls=True - warn_return_any=True We've also toggled these two: - warn_redundant_casts=True - warn_unused_ignores=True Finally, we check for - check_untyped_defs=True For the full --strict set, we'd also need: - disallow_untyped_defs=True But that, we'll need better typedefs.
* add Optional where needed (even if it was implicit thru = None) * fix JailConfig type hints: we were pointing to the wrong thing * Logger now has types * error: take *Any* value, it's an error after all
This is an addendum to #157 (Resource is an abstract class, be clear about it)
This patch is an addendum to #157 (Resource is an abstract class, be clear about it)
rather than implicitly setting a parameter `Optional[foo]`, by simply assigning it `None`, we make it explicit. This will be encouraged in newer mypy releases, and is currently enforced through `--strict`, so let's get going!
rather than implicitly setting a parameter `Optional[foo]`, by simply assigning it `None`, we make it explicit. This will be encouraged in newer mypy releases, and is currently enforced through `--strict`, so let's get going!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
successor of #131 ?