Do not dynamically load OnboardingViews from url, which now have descriptive names #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2022
jarolrod
force-pushed
the
wizard-page-instantiation
branch
from
bfc2bbc to
15012e7
Compare
It has just been merged.
One more time? 😄 |
jarolrod
force-pushed
the
wizard-page-instantiation
branch
from
15012e7 to
3d3b62e
Compare
|
Needs rebase again. |
This is not used at all. This is a remnant from a time where the idea was to have the navbar encapsulated within the Wizard control, and this bool would dictate what navbutton to display. We have since moved to each page provides its navbar and its navbuttons.
jarolrod
force-pushed
the
wizard-page-instantiation
branch
from
3d3b62e to
cc8c7e7
Compare
johnny9
suggested changes
Dec 11, 2022
|
Looks like controls/Wizard.qml can be removed. |
This is no longer providing any value and is not needed.
jarolrod
force-pushed
the
wizard-page-instantiation
branch
from
cc8c7e7 to
6c29ddf
Compare
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#198 Rebased-From: 9cc991f
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
This is not used at all. This is a remnant from a time where the idea was to have the navbar encapsulated within the Wizard control, and this bool would dictate what navbutton to display. We have since moved to each page provides its navbar and its navbuttons. Github-Pull: bitcoin-core#198 Rebased-From: 5120735
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#198 Rebased-From: 8619e50
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
This is no longer providing any value and is not needed. Github-Pull: bitcoin-core#198 Rebased-From: 6c29ddf
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#198 Rebased-From: 9cc991f
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
This is not used at all. This is a remnant from a time where the idea was to have the navbar encapsulated within the Wizard control, and this bool would dictate what navbutton to display. We have since moved to each page provides its navbar and its navbuttons. Github-Pull: bitcoin-core#198 Rebased-From: 5120735
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#198 Rebased-From: 8619e50
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
This is no longer providing any value and is not needed. Github-Pull: bitcoin-core#198 Rebased-From: 6c29ddf
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#198 Rebased-From: 9cc991f
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
This is not used at all. This is a remnant from a time where the idea was to have the navbar encapsulated within the Wizard control, and this bool would dictate what navbutton to display. We have since moved to each page provides its navbar and its navbuttons. Github-Pull: bitcoin-core#198 Rebased-From: 5120735
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#198 Rebased-From: 8619e50
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
This is no longer providing any value and is not needed. Github-Pull: bitcoin-core#198 Rebased-From: 6c29ddf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing the desire for descriptive names for the onboarding views as well as (partially) addressing an old piece of feedback from promag about loading pages.
In regards to the second issue this is addressing, the current state of the PR doesn't perfectly address this as there doesn't seem to be a way of given a SwipeView children after it's already been declared. So this PR just doesn't use the Wizard control anymore (which already has limited value and is vulnerable to removal), and deletes it as well.
Desktop
Master
PR