Skip to content

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Dec 7, 2022

This makes the default values of the TextButton control more usable to it's actual usage.

Desktop

master pr
master-7 Screen Shot 2022-12-07 at 7 09 23 PM
master pr
master-9 Screen Shot 2022-12-07 at 7 09 29 PM

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@jarolrod jarolrod changed the title More usable TextButton control default values Better TextButton control default values Dec 7, 2022
@jarolrod jarolrod force-pushed the text-control-defaults branch from efe93c5 to 59fa1cf Compare December 9, 2022 18:28
@jarolrod
Copy link
Member Author

jarolrod commented Dec 9, 2022

updated from efe93c5 to 59fa1cf

Changes: rebased over master

@hebasto
Copy link
Member

hebasto commented Dec 10, 2022

Rebase?

@jarolrod jarolrod force-pushed the text-control-defaults branch from 59fa1cf to d19bc92 Compare December 10, 2022 16:57
@jarolrod
Copy link
Member Author

updated from 59fa1cf to d19bc92

changes: rebased over master

@jarolrod
Copy link
Member Author

updated from d19bc92 to 9e99113

changes: rebased over changes to base pr

@jarolrod jarolrod force-pushed the text-control-defaults branch from 9e99113 to 956605f Compare December 14, 2022 08:09
@jarolrod
Copy link
Member Author

updated from d19bc92 to 9e99113

changes: rebased over changes on master

@jarolrod
Copy link
Member Author

cc @johnny9 @shaavan

Copy link
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 956605f

Good clean up. No QML issues when running.

@hebasto hebasto merged commit fd4e57f into bitcoin-core:main Dec 17, 2022
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
johnny9 pushed a commit to johnny9/bitcoin-core-app that referenced this pull request Jul 4, 2025
3763a41 qml: make the TextButton control default values more usable (Jarol Rodriguez)

Pull request description:

  This makes the default values of the TextButton control more usable to it's actual usage.
  ## Desktop

  | master | pr |
  | ------ | -- |
  | <img width="752" alt="master-7" src="https://user-images.githubusercontent.com/23396902/206324636-ba5d9192-45e2-4e8b-9095-898832e53b16.png"> | <img width="752" alt="Screen Shot 2022-12-07 at 7 09 23 PM" src="https://user-images.githubusercontent.com/23396902/206324655-5f2a26c1-5595-4a19-acbb-1886c2e5278a.png"> |

  | master | pr |
  | ------ | -- |
  | <img width="752" alt="master-9" src="https://user-images.githubusercontent.com/23396902/206324735-f5417dd2-3719-4c16-9e41-b07fd414dbea.png"> | <img width="752" alt="Screen Shot 2022-12-07 at 7 09 29 PM" src="https://user-images.githubusercontent.com/23396902/206324747-657084ce-a26e-44fe-8599-b2210a8c83d0.png"> |

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/199)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/199)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/199)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/199)

ACKs for top commit:
  johnny9:
    ACK 3763a41

Tree-SHA512: cfc80ed64d2fecf137ad775f0bed754eb72cbec8e13c40f746419295908e6ee553e2ac333f5e28948f78245c97d78ddd7e99f42632f86c7fe9d43cc2116eaffc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants