Skip to content

Better TextButton control default values #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Dec 7, 2022

This makes the default values of the TextButton control more usable to it's actual usage.

Desktop

master pr
master-7 Screen Shot 2022-12-07 at 7 09 23 PM
master pr
master-9 Screen Shot 2022-12-07 at 7 09 29 PM

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@jarolrod jarolrod changed the title More usable TextButton control default values Better TextButton control default values Dec 7, 2022
@jarolrod jarolrod force-pushed the text-control-defaults branch from efe93c5 to 59fa1cf Compare December 9, 2022 18:28
@jarolrod
Copy link
Member Author

jarolrod commented Dec 9, 2022

updated from efe93c5 to 59fa1cf

Changes: rebased over master

@hebasto
Copy link
Member

hebasto commented Dec 10, 2022

Rebase?

@jarolrod jarolrod force-pushed the text-control-defaults branch from 59fa1cf to d19bc92 Compare December 10, 2022 16:57
@jarolrod
Copy link
Member Author

updated from 59fa1cf to d19bc92

changes: rebased over master

@jarolrod
Copy link
Member Author

updated from d19bc92 to 9e99113

changes: rebased over changes to base pr

@jarolrod jarolrod force-pushed the text-control-defaults branch from 9e99113 to 956605f Compare December 14, 2022 08:09
@jarolrod
Copy link
Member Author

updated from d19bc92 to 9e99113

changes: rebased over changes on master

@jarolrod
Copy link
Member Author

cc @johnny9 @shaavan

Copy link
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 956605f

Good clean up. No QML issues when running.

@hebasto hebasto merged commit fd4e57f into bitcoin-core:main Dec 17, 2022
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants