Introducing the node settings views #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase needed. |
jarolrod
force-pushed
the
node-settings-view
branch
from
e7763aa to
942a3b4
Compare
johnny9
suggested changes
Dec 11, 2022
| ColumnLayout { | ||
| spacing: 0 | ||
| width: parent.width | ||
| ColumnLayout { |
There was a problem hiding this comment.
Seems like one of these ColumnLayouts can be removed
There was a problem hiding this comment.
this allows for the table to expand but be a max width of 450, we use the same nested approach in the InformationPage control; open to better ways of accomplishing this
There was a problem hiding this comment.
Can use width: Math.min(parent.width, 450)
jarolrod
force-pushed
the
node-settings-view
branch
from
942a3b4 to
06235ca
Compare
Currently, the parent SwipeView of the AboutOptions page needs to have an id of introductions. We abuse the knowledge that in our codebase we will have that available, but this limits when and where the AboutOptions can be used. This entangles the About and Developer options so that we can avoid this, and have these pages truly be reusable. Co-Authored-By: Johnny Carlson <[email protected]>
Co-Authored-By: Johnny Carlson <[email protected]>
jarolrod
force-pushed
the
node-settings-view
branch
from
06235ca to
6037471
Compare
johnny9
suggested changes
Dec 14, 2022
| ColumnLayout { | ||
| spacing: 0 | ||
| anchors.fill: parent | ||
| ColumnLayout { |
There was a problem hiding this comment.
Here's another double ColumnLayout. I think we should reduce the layers here or use a different top level Item since using another Layout component isn't necessary.
There was a problem hiding this comment.
maybe we can leave it to a follow-up pr to address the nested columnlayouts throughout the code?
hebasto
added a commit
that referenced
this pull request
Dec 17, 2022
4dc32c4 qml: remove extra ColumnLayouts (Johnny Carlson) Pull request description: Follow up to #203 [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/210) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/210) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/210) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/210) ACKs for top commit: jarolrod: tACK 4dc32c4 Tree-SHA512: 7c03eb2ffce728d3b353aca05806b239f838b4a81f4ec9c5429cb48e0ce1591596c64ca1c253f788cdb3ada3052d92f992d26539afd2458636f884fa750b7e0e
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Currently, the parent SwipeView of the AboutOptions page needs to have an id of introductions. We abuse the knowledge that in our codebase we will have that available, but this limits when and where the AboutOptions can be used. This entangles the About and Developer options so that we can avoid this, and have these pages truly be reusable. Github-Pull: bitcoin-core#203 Rebased-From: 6ac40e8 Co-Authored-By: Johnny Carlson <[email protected]>
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#203 Rebased-From: 6037471 Co-Authored-By: Johnny Carlson <[email protected]>
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Currently, the parent SwipeView of the AboutOptions page needs to have an id of introductions. We abuse the knowledge that in our codebase we will have that available, but this limits when and where the AboutOptions can be used. This entangles the About and Developer options so that we can avoid this, and have these pages truly be reusable. Github-Pull: bitcoin-core#203 Rebased-From: 6ac40e8 Co-Authored-By: Johnny Carlson <[email protected]>
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#203 Rebased-From: 6037471 Co-Authored-By: Johnny Carlson <[email protected]>
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Currently, the parent SwipeView of the AboutOptions page needs to have an id of introductions. We abuse the knowledge that in our codebase we will have that available, but this limits when and where the AboutOptions can be used. This entangles the About and Developer options so that we can avoid this, and have these pages truly be reusable. Github-Pull: bitcoin-core#203 Rebased-From: 6ac40e8 Co-Authored-By: Johnny Carlson <[email protected]>
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#203 Rebased-From: 6037471 Co-Authored-By: Johnny Carlson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the views that would allow for settings configuration after the user has finished onboarding and the node has started to run.
For several reasons this also entangles the About and Developer options and entangles them into their own independent SwipeView, which means that we only need to instantiate SettingsAbout. There isn't a use case for the Developer options to be shown independently.
Follow-ups: