Make sure we submit work even if we visited a camera. #20595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
added
C-Bug
andriyDev
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
This seems like a nice fix regardless - at least this way we don't end up with an uninitialized texture! I'd even be ok shipping without #20407 (though that still introduces a frame delay for real rendering which isn't great).
alice-i-cecile
requested changes
Aug 15, 2025
alice-i-cecile
added
S-Waiting-on-Author
JMS55
reviewed
Aug 15, 2025
tychedelia
added
S-Needs-Review
JMS55
reviewed
Aug 16, 2025
JMS55
approved these changes
Aug 16, 2025
tychedelia
added
S-Ready-For-Final-Review
Zeophlite
approved these changes
Aug 16, 2025
alice-i-cecile
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix to #20318. We have existing code making sure that we do work on a swapchain in
CameraDriverNode. However, it's only protecting against the case where we have no cameras spawned. We also need to check that we actually did any rendering work, even if we have cameras in the scene.Tested on macOS.