Skip to content

Revert BlitPlugin RenderStartup #20370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert BlitPlugin RenderStartup #20370

wants to merge 1 commit into from

Conversation

Zeophlite
Copy link
Contributor

Objective

Solution

  • Revert BlitPlugin changes

Testing

  • 3d_shapes example

@cart cart added this to the 0.17 milestone Aug 1, 2025
@atlv24
Copy link
Contributor

atlv24 commented Aug 1, 2025

hold the phone on this one, we may need a full revert of the core pipelines changes.

@atlv24
Copy link
Contributor

atlv24 commented Aug 2, 2025

nevermind, a full revert of the core pipelines isnt enough, we need a different fix for the STATUS_HEAP_CORRUPTION issue, this is fine

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen X-Contentious There are nontrivial implications that should be thought through S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 3, 2025
@Zeophlite
Copy link
Contributor Author

Hopefully #20407 will be merged, then this can be closed, but will keep open til 0.17 release time just in case

@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 5, 2025
@alice-i-cecile
Copy link
Member

With #20595 merged, I don't think this is a critical enough fix to merge a reversion. Closing: we're going to continue to explore more complex but comprehensive solutions along the lines of #20407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Blocked This cannot move forward until something else changes X-Contentious There are nontrivial implications that should be thought through
Projects
Rendering
Status: Done
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

pink screen on startup
4 participants
@Zeophlite @atlv24 @alice-i-cecile @cart