BUG: An argument $reverse of method \PhpImap\Imap::sort() has type boolean from PHP version 8 only #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oolean from PHP version 8 only
alebedev80
changed the title
Contributor
Author
|
@barbushin @rmontagud @Theaxiom @hexathos @JellyBellyDev hey somebody please review and merge PR! |
|
@barbushin @rmontagud @Theaxiom @hexathos @JellyBellyDev @alebedev80 The following commit from 4.3.0 is causing this "imap_sort() expects parameter 3 to be int, bool given" error:
|
Contributor
Author
|
@mattyhansen seems this repo abandoned |
Contributor
|
@alebedev80 sorry but I am not one of the maintainers, a long time ago I contributed a PR but I have no power over this repo. |
Sebbo94BY
reviewed
Feb 16, 2022
Sebbo94BY
reviewed
Feb 16, 2022
…oolean from PHP version 8 only
…oolean from PHP version 8 only
Contributor
Author
|
@Sebi94nbg i've fixed a code, please review it again. |
Collaborator
|
Released in version 4.5.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment (please complete the following information):
Describe the bug
The $reverse variable type conversion from boolean to integer has been removed in this commit, but imap_open() before PHP version 8 only accepts integer type. Thus, in PHP 7 this code ends with the error:
Also i found strange assignment in \PhpImap\Imap::sort():
I've added PHP version detection and removed legacy code.
Please review it.
Thank you!