Fix imap_sort() for PHP < 8.0 #660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting the following error on PHP versions lower than 8.0 ```Uncaught TypeError: imap_sort() expects parameter 3 to be int, bool given``` Since PHP 8.0.0 reverse is now bool instead of int https://www.php.net/manual/en/function.imap-sort.php
Contributor
|
@barbushin @rmontagud @Theaxiom @hexathos @JellyBellyDev @alebedev80 The following commit from 4.3.0 is causing this "imap_sort() expects parameter 3 to be int, bool given" error:
|
Contributor
|
sorry but I am not one of the maintainers, a long time ago I contributed a PR but I have no power over this repo. |
Contributor
|
As @JellyBellyDev I just contributed a PR and have no power over this repo, but this is an issue i will face eventually when I have to upgrade to PHP8.x |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the following error on PHP versions lower than 8.0
Uncaught TypeError: imap_sort() expects parameter 3 to be int, bool givenSince PHP 8.0.0 reverse is now bool instead of int
https://www.php.net/manual/en/function.imap-sort.php