Skip to content

BUG: An argument $reverse of method \PhpImap\Imap::sort() has type boolean from PHP version 8 only #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2022
Merged

BUG: An argument $reverse of method \PhpImap\Imap::sort() has type boolean from PHP version 8 only #659

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58072c5
BUG: And argument $reverse of method \PhpImap\Imap::sort() has type b…
alebedev80 Feb 7, 2022
d620388
BUG: And argument $reverse of method \PhpImap\Imap::sort() has type b…
alebedev80 Feb 17, 2022
0b30fb7
BUG: And argument $reverse of method \PhpImap\Imap::sort() has type b…
alebedev80 Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/PhpImap/Imap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use const IMAP_WRITETIMEOUT;
use InvalidArgumentException;
use const NIL;
use const PHP_MAJOR_VERSION;
use PhpImap\Exceptions\ConnectionException;
use const SE_FREE;
use const SORTARRIVAL;
Expand Down Expand Up @@ -911,11 +912,18 @@ public static function sort(
\imap_errors(); // flush errors

$imap_stream = self::EnsureConnection($imap_stream, __METHOD__, 1);
$reverse = $reverse;

/** @var int */
$criteria = $criteria;

if (PHP_MAJOR_VERSION < 8) {
/** @var int */
$reverse = (int) $reverse;
} else {
/** @var bool */
$reverse = $reverse;
}

if (null !== $search_criteria && null !== $charset) {
$result = \imap_sort(
$imap_stream,
Expand Down