fix: unhashable type: 'dict_node' when referencing RestApiId by Ref in Lambda event mapping on redeploy check #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the error of when referencing an API via Ref so that the dictionary check actually occurs. This makes the type checks equivalent and isn't as restrictive as the OrderedDict class
|
@patrickgreenwell Thank you for fixing this!! |
ShreyaGangishetty
approved these changes
Jan 15, 2020
Codecov Report
@@ Coverage Diff @@
## develop #1396 +/- ##
===========================================
- Coverage 94.44% 94.44% -0.01%
===========================================
Files 78 78
Lines 4557 4556 -1
Branches 911 911
===========================================
- Hits 4304 4303 -1
Misses 119 119
Partials 134 134
Continue to review full report at Codecov.
|
keetonian
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the error of when referencing an API via Ref so that the dictionary check actually occurs. This makes the type checks equivalent and isn't as restrictive as the OrderedDict class. Helps for when things like cfn-lint pass in templates which is where I noticed the bug after updating to the latest version.
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.