Skip to content

fix: unhashable type: 'dict_node' when referencing RestApiId by Ref in Lambda event mapping on redeploy check #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2020
+1 −2
Merged

fix: unhashable type: 'dict_node' when referencing RestApiId by Ref in Lambda event mapping on redeploy check #1396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions samtranslator/translator/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import copy
from samtranslator.model import ResourceTypeResolver, sam_resources
from collections import OrderedDict
from samtranslator.translator.verify_logical_id import verify_unique_logical_id
from samtranslator.model.preferences.deployment_preference_collection import DeploymentPreferenceCollection
from samtranslator.model.exceptions import (
Expand Down Expand Up @@ -52,7 +51,7 @@ def _get_function_names(self, resource_dict, intrinsics_resolver):
# adds to the function_names dict with key as the api_name and value as the function_name
if item.get("Type") == "Api" and item.get("Properties") and item.get("Properties").get("RestApiId"):
rest_api = item.get("Properties").get("RestApiId")
if type(rest_api) == dict or isinstance(rest_api, OrderedDict):
if type(rest_api) == dict or isinstance(rest_api, dict):
api_name = item.get("Properties").get("RestApiId").get("Ref")
else:
api_name = item.get("Properties").get("RestApiId")
Expand Down