feat: Trigger auto publish alias on env var/memorysize change #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2019 23:02
… changed while AutoPublishAlias is enabled. Update sam_resources to include function's environment variables and memory config in the input to logical_id_generator which creates SHA hash.
… changed while AutoPublishAlias is enabled. Update tests which hardcode expected logicalid.
to-mc
changed the title
to-mc
changed the title
|
Travis build is running against master instead of develop. |
…cation-model into autopublishalias-on-envvar-change
Codecov Report
@@ Coverage Diff @@
## develop #1310 +/- ##
===========================================
+ Coverage 94.38% 94.43% +0.04%
===========================================
Files 78 78
Lines 4310 4672 +362
Branches 862 932 +70
===========================================
+ Hits 4068 4412 +344
- Misses 115 121 +6
- Partials 127 139 +12
Continue to review full report at Codecov.
|
keetonian
approved these changes
Jan 31, 2020
ShreyaGangishetty
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1305, #413
Description of changes: Update how Logical ID is generated for lambda function version so it takes into account environment variables and memorysize configuration. Changes to these values will now cause an update to the alias when AutoPublishAlias is enabled on the function.
Description of how you validated changes: Translated (sam-translate.py) and deployed function several times with (and without) changing values for env vars and memorysize configuration to confirm expected functionality.
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.