feat: Trigger auto publish alias on env var/memorysize change (#1310)

Author: cakepietoast

samtranslator/model/sam_resources.py

@@ -661,7 +661,17 @@ def _construct_version(self, function, intrinsics_resolver, code_sha256=None):
         # SHA Collisions: For purposes of triggering a new update, we are concerned about just the difference previous
         #                 and next hashes. The chances that two subsequent hashes collide is fairly low.
         prefix = "{id}Version".format(id=self.logical_id)
-        logical_id = logical_id_generator.LogicalIdGenerator(prefix, code_dict, code_sha256).gen()
+        logical_dict = {}
+        try:
+            logical_dict = code_dict.copy()
+        except (AttributeError, UnboundLocalError):
+            pass
+        else:
+            if function.Environment:
+                logical_dict.update(function.Environment)
+            if function.MemorySize:
+                logical_dict.update({"MemorySize": function.MemorySize})
+        logical_id = logical_id_generator.LogicalIdGenerator(prefix, logical_dict, code_sha256).gen()
 
         attributes = self.get_passthrough_resource_attributes()
         if attributes is None:

tests/translator/output/aws-cn/function_with_event_dest_basic.json

@@ -121,21 +121,12 @@
         "Runtime": "nodejs12.x"
       }
     }, 
-    "MyTestFunctionVersion948f7f815d": {
-      "DeletionPolicy": "Retain", 
-      "Type": "AWS::Lambda::Version", 
-      "Properties": {
-        "FunctionName": {
-          "Ref": "MyTestFunction"
-        }
-      }
-    }, 
     "MyTestFunctionAliaslive": {
       "Type": "AWS::Lambda::Alias", 
       "Properties": {
         "FunctionVersion": {
           "Fn::GetAtt": [
-            "MyTestFunctionVersion948f7f815d", 
+            "MyTestFunctionVersiondaf9da458d", 
             "Version"
           ]
         }, 
@@ -144,6 +135,15 @@
         }, 
         "Name": "live"
       }
+    }, 
+    "MyTestFunctionVersiondaf9da458d": {
+      "DeletionPolicy": "Retain", 
+      "Type": "AWS::Lambda::Version", 
+      "Properties": {
+        "FunctionName": {
+          "Ref": "MyTestFunction"
+        }
+      }
     }
   }
 }

tests/translator/output/aws-cn/globals_for_function.json

@@ -144,7 +144,7 @@
       "Properties": {
         "FunctionVersion": {
           "Fn::GetAtt": [
-            "FunctionWithOverridesVersion640128d35d", 
+            "FunctionWithOverridesVersion096ed3b52b",
             "Version"
           ]
         }, 
@@ -211,7 +211,7 @@
       "Properties": {
         "FunctionVersion": {
           "Fn::GetAtt": [
-            "MinimalFunctionVersionfb7aeaa544", 
+            "MinimalFunctionVersion0a06fc8fb1",
             "Version"
           ]
         }, 
@@ -221,7 +221,7 @@
         "Name": "live"
       }
     }, 
-    "FunctionWithOverridesVersion640128d35d": {
+    "FunctionWithOverridesVersion096ed3b52b": {
       "DeletionPolicy": "Retain", 
       "Type": "AWS::Lambda::Version", 
       "Properties": {
@@ -230,7 +230,7 @@
         }
       }
     }, 
-    "MinimalFunctionVersionfb7aeaa544": {
+    "MinimalFunctionVersion0a06fc8fb1": {
       "DeletionPolicy": "Retain", 
       "Type": "AWS::Lambda::Version", 
       "Properties": {

tests/translator/output/aws-us-gov/function_with_event_dest_basic.json

@@ -121,21 +121,12 @@
         "Runtime": "nodejs12.x"
       }
     }, 
-    "MyTestFunctionVersion948f7f815d": {
-      "DeletionPolicy": "Retain", 
-      "Type": "AWS::Lambda::Version", 
-      "Properties": {
-        "FunctionName": {
-          "Ref": "MyTestFunction"
-        }
-      }
-    }, 
     "MyTestFunctionAliaslive": {
       "Type": "AWS::Lambda::Alias", 
       "Properties": {
         "FunctionVersion": {
           "Fn::GetAtt": [
-            "MyTestFunctionVersion948f7f815d", 
+            "MyTestFunctionVersiondaf9da458d", 
             "Version"
           ]
         }, 
@@ -144,6 +135,15 @@
         }, 
         "Name": "live"
       }
+    }, 
+    "MyTestFunctionVersiondaf9da458d": {
+      "DeletionPolicy": "Retain", 
+      "Type": "AWS::Lambda::Version", 
+      "Properties": {
+        "FunctionName": {
+          "Ref": "MyTestFunction"
+        }
+      }
     }
   }
 }

tests/translator/output/aws-us-gov/globals_for_function.json

@@ -144,7 +144,7 @@
       "Properties": {
         "FunctionVersion": {
           "Fn::GetAtt": [
-            "FunctionWithOverridesVersion640128d35d", 
+            "FunctionWithOverridesVersion096ed3b52b",
             "Version"
           ]
         }, 
@@ -211,7 +211,7 @@
       "Properties": {
         "FunctionVersion": {
           "Fn::GetAtt": [
-            "MinimalFunctionVersionfb7aeaa544", 
+            "MinimalFunctionVersion0a06fc8fb1",
             "Version"
           ]
         }, 
@@ -221,7 +221,7 @@
         "Name": "live"
       }
     }, 
-    "FunctionWithOverridesVersion640128d35d": {
+    "FunctionWithOverridesVersion096ed3b52b": {
       "DeletionPolicy": "Retain", 
       "Type": "AWS::Lambda::Version", 
       "Properties": {
@@ -230,7 +230,7 @@
         }
       }
     }, 
-    "MinimalFunctionVersionfb7aeaa544": {
+    "MinimalFunctionVersion0a06fc8fb1": {
       "DeletionPolicy": "Retain", 
       "Type": "AWS::Lambda::Version", 
       "Properties": {

tests/translator/output/function_with_event_dest_basic.json

@@ -121,21 +121,12 @@
         "Runtime": "nodejs12.x"
       }
     }, 
-    "MyTestFunctionVersion948f7f815d": {
-      "DeletionPolicy": "Retain", 
-      "Type": "AWS::Lambda::Version", 
-      "Properties": {
-        "FunctionName": {
-          "Ref": "MyTestFunction"
-        }
-      }
-    }, 
     "MyTestFunctionAliaslive": {
       "Type": "AWS::Lambda::Alias", 
       "Properties": {
         "FunctionVersion": {
           "Fn::GetAtt": [
-            "MyTestFunctionVersion948f7f815d", 
+            "MyTestFunctionVersiondaf9da458d", 
             "Version"
           ]
         }, 
@@ -144,6 +135,15 @@
         }, 
         "Name": "live"
       }
+    }, 
+    "MyTestFunctionVersiondaf9da458d": {
+      "DeletionPolicy": "Retain", 
+      "Type": "AWS::Lambda::Version", 
+      "Properties": {
+        "FunctionName": {
+          "Ref": "MyTestFunction"
+        }
+      }
     }
   }
 }

tests/translator/output/globals_for_function.json

@@ -144,7 +144,7 @@
       "Properties": {
         "FunctionVersion": {
           "Fn::GetAtt": [
-            "FunctionWithOverridesVersion640128d35d", 
+            "FunctionWithOverridesVersion096ed3b52b",
             "Version"
           ]
         }, 
@@ -211,7 +211,7 @@
       "Properties": {
         "FunctionVersion": {
           "Fn::GetAtt": [
-            "MinimalFunctionVersionfb7aeaa544", 
+            "MinimalFunctionVersion0a06fc8fb1",
             "Version"
           ]
         }, 
@@ -221,7 +221,7 @@
         "Name": "live"
       }
     }, 
-    "FunctionWithOverridesVersion640128d35d": {
+    "FunctionWithOverridesVersion096ed3b52b": {
       "DeletionPolicy": "Retain", 
       "Type": "AWS::Lambda::Version", 
       "Properties": {
@@ -230,7 +230,7 @@
         }
       }
     }, 
-    "MinimalFunctionVersionfb7aeaa544": {
+    "MinimalFunctionVersion0a06fc8fb1": {
       "DeletionPolicy": "Retain", 
       "Type": "AWS::Lambda::Version", 
       "Properties": {