Skip to content

feat: Trigger auto publish alias on env var/memorysize change #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2020
Merged

feat: Trigger auto publish alias on env var/memorysize change #1310

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45b835d
feat: trigger auto publish new alias when Env var or Memory Config is…
Dec 9, 2019
d36f8b3
feat: trigger auto publish new alias when Env var or Memory Config is…
Dec 9, 2019
c03ff29
Merge branch 'develop' of https://github.com/awslabs/serverless-appli…
Dec 10, 2019
55df4db
Merge branch 'develop' into autopublishalias-on-envvar-change
keetonian Jan 31, 2020
5775e1f
Fix failing tests
keetonian Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion samtranslator/model/sam_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,17 @@ def _construct_version(self, function, intrinsics_resolver):
# SHA Collisions: For purposes of triggering a new update, we are concerned about just the difference previous
# and next hashes. The chances that two subsequent hashes collide is fairly low.
prefix = "{id}Version".format(id=self.logical_id)
logical_id = logical_id_generator.LogicalIdGenerator(prefix, code_dict).gen()
logical_dict = {}
try:
logical_dict = code_dict.copy()
except (AttributeError, UnboundLocalError):
pass
else:
if function.Environment:
logical_dict.update(function.Environment)
if function.MemorySize:
logical_dict.update({'MemorySize': function.MemorySize})
logical_id = logical_id_generator.LogicalIdGenerator(prefix, logical_dict).gen()

attributes = self.get_passthrough_resource_attributes()
if attributes is None:
Expand Down
8 changes: 4 additions & 4 deletions tests/translator/output/aws-cn/globals_for_function.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
"Properties": {
"FunctionVersion": {
"Fn::GetAtt": [
"FunctionWithOverridesVersion640128d35d",
"FunctionWithOverridesVersion096ed3b52b",
"Version"
]
},
Expand Down Expand Up @@ -211,7 +211,7 @@
"Properties": {
"FunctionVersion": {
"Fn::GetAtt": [
"MinimalFunctionVersionfb7aeaa544",
"MinimalFunctionVersion0a06fc8fb1",
"Version"
]
},
Expand All @@ -221,7 +221,7 @@
"Name": "live"
}
},
"FunctionWithOverridesVersion640128d35d": {
"FunctionWithOverridesVersion096ed3b52b": {
"DeletionPolicy": "Retain",
"Type": "AWS::Lambda::Version",
"Properties": {
Expand All @@ -230,7 +230,7 @@
}
}
},
"MinimalFunctionVersionfb7aeaa544": {
"MinimalFunctionVersion0a06fc8fb1": {
"DeletionPolicy": "Retain",
"Type": "AWS::Lambda::Version",
"Properties": {
Expand Down
8 changes: 4 additions & 4 deletions tests/translator/output/aws-us-gov/globals_for_function.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
"Properties": {
"FunctionVersion": {
"Fn::GetAtt": [
"FunctionWithOverridesVersion640128d35d",
"FunctionWithOverridesVersion096ed3b52b",
"Version"
]
},
Expand Down Expand Up @@ -211,7 +211,7 @@
"Properties": {
"FunctionVersion": {
"Fn::GetAtt": [
"MinimalFunctionVersionfb7aeaa544",
"MinimalFunctionVersion0a06fc8fb1",
"Version"
]
},
Expand All @@ -221,7 +221,7 @@
"Name": "live"
}
},
"FunctionWithOverridesVersion640128d35d": {
"FunctionWithOverridesVersion096ed3b52b": {
"DeletionPolicy": "Retain",
"Type": "AWS::Lambda::Version",
"Properties": {
Expand All @@ -230,7 +230,7 @@
}
}
},
"MinimalFunctionVersionfb7aeaa544": {
"MinimalFunctionVersion0a06fc8fb1": {
"DeletionPolicy": "Retain",
"Type": "AWS::Lambda::Version",
"Properties": {
Expand Down
8 changes: 4 additions & 4 deletions tests/translator/output/globals_for_function.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
"Properties": {
"FunctionVersion": {
"Fn::GetAtt": [
"FunctionWithOverridesVersion640128d35d",
"FunctionWithOverridesVersion096ed3b52b",
"Version"
]
},
Expand Down Expand Up @@ -211,7 +211,7 @@
"Properties": {
"FunctionVersion": {
"Fn::GetAtt": [
"MinimalFunctionVersionfb7aeaa544",
"MinimalFunctionVersion0a06fc8fb1",
"Version"
]
},
Expand All @@ -221,7 +221,7 @@
"Name": "live"
}
},
"FunctionWithOverridesVersion640128d35d": {
"FunctionWithOverridesVersion096ed3b52b": {
"DeletionPolicy": "Retain",
"Type": "AWS::Lambda::Version",
"Properties": {
Expand All @@ -230,7 +230,7 @@
}
}
},
"MinimalFunctionVersionfb7aeaa544": {
"MinimalFunctionVersion0a06fc8fb1": {
"DeletionPolicy": "Retain",
"Type": "AWS::Lambda::Version",
"Properties": {
Expand Down