Fix: malformed input when update without atrributes changes #41
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Julian-Chu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow
bot
added
the
needs-ok-to-test
|
Hi @Julian-Chu. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ack-prow
bot
added
the
do-not-merge/work-in-progress
| // note(Julian-Chu): SetAttributes API without any attributes | ||
| // will return MalformedInput(message: End of list found where not expected) error. | ||
| // if there are no attributes in the input, | ||
| // We need to set minimal one default value, or use customUpdate to skip api call. | ||
| if len(input.Attributes) == 0 { | ||
| input.Attributes = map[string]*string{ | ||
| "DelaySeconds": latest.ko.Spec.DelaySeconds, | ||
| } | ||
| } |
There was a problem hiding this comment.
shouldn't we fix the delta function instead? Also i don't understand how we get to this block when we're having:
if delta.DifferentAt("Spec.Tags") {
if err := rm.syncTags(ctx, desired, latest); err != nil {
return nil, err
}
}
if !delta.DifferentExcept("Spec.Tags") {
return desired, nil
}
There was a problem hiding this comment.
!! you're right, we should fix delta.
I quickly check the delta:
looks some default values returned from API.
I will find some time next week to fix it.
|
/ok-to-test |
ack-prow
bot
added
ok-to-test
|
Issues go stale after 180d of inactivity. |
ack-prow
bot
added
the
lifecycle/stale
|
@Julian-Chu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Fixing in #60 |
3 participants
Issue #1969
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.