Skip to content

Conversation

@a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Oct 11, 2024

Fixes:

This patch regenerates the controller after modifying the Queue generator
config with the following changes:

  1. Add late initialization for several attributes:
  • DelaySeconds
  • MaximumMessageSize
  • MessageRetentionPeriod
  • ReceiveMessageWaitTimeSeconds
  • VisibilityTimeout

These fields will now be populated from the AWS API if not specified by the user.

  1. Add a new attribute:
  • SQSManagedSseEnabled

This allows users to enable or disable SQS managed server side encryption..

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ibute

This patch regenerates the controller after modifying the `Queue` generator
config with the following changes:

1. Add late initialization for several attributes:
  - `DelaySeconds`
  - `MaximumMessageSize`
  - `MessageRetentionPeriod`
  - `ReceiveMessageWaitTimeSeconds`
  - `VisibilityTimeout`

These fields will now be populated from the AWS API if not specified by the user.

2. Add a new attribute:
  - `SQSManagedSseEnabled`

This allows users to enable or disable SQS managed server side encryption..
@ack-prow ack-prow bot requested a review from jaypipes October 11, 2024 23:36
@ack-prow ack-prow bot added the approved label Oct 11, 2024
@ack-prow
Copy link

ack-prow bot commented Oct 11, 2024

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sqs-verify-attribution 07953de link false /test sqs-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-bot
Copy link
Collaborator

ack-bot commented Oct 11, 2024

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
@ack-prow
Copy link

ack-prow bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 369e2de into aws-controllers-k8s:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants