Skip to content

Fix: malformed input when update without atrributes changes #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Julian-Chu wants to merge 2 commits into from
Closed

Fix: malformed input when update without atrributes changes #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86d3670
set DelaySeconds default value for setQueueAttributes call when no at…
Julian-Chu Dec 16, 2023
66b8d79
add comments
Julian-Chu Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2023-09-14T23:52:46Z"
build_date: "2023-12-16T08:34:38Z"
build_hash: 892f29d00a4c4ad21a2fa32919921de18190979d
go_version: go1.21.0
version: v0.27.1
api_directory_checksum: 4538a2a4e75334bd4ab5ebd8dd9f73b69662d197
api_version: v1alpha1
aws_sdk_go_version: v1.44.93
generator_config_info:
file_checksum: 9eac8d3730cfe212c3a88aa5173b22de93c2d0b7
file_checksum: c373e8ad8d189318656ef1f90a73a1f3e319bf89
original_file_name: generator.yaml
last_modification:
reason: API generation
2 changes: 2 additions & 0 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ resources:
template_path: hooks/queue/sdk_get_attributes_post_set_output.go.tpl
sdk_update_pre_build_request:
template_path: hooks/queue/sdk_update_pre_build_request.go.tpl
sdk_update_post_build_request:
template_path: hooks/queue/sdk_update_post_build_request.go.tpl
fields:
DelaySeconds:
is_attribute: true
Expand Down
2 changes: 2 additions & 0 deletions generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ resources:
template_path: hooks/queue/sdk_get_attributes_post_set_output.go.tpl
sdk_update_pre_build_request:
template_path: hooks/queue/sdk_update_pre_build_request.go.tpl
sdk_update_post_build_request:
template_path: hooks/queue/sdk_update_post_build_request.go.tpl
fields:
DelaySeconds:
is_attribute: true
Expand Down
9 changes: 9 additions & 0 deletions pkg/resource/queue/sdk.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions templates/hooks/queue/sdk_update_post_build_request.go.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// note(Julian-Chu): SetAttributes API without any attributes
// will return MalformedInput(message: End of list found where not expected) error.
// if there are no attributes in the input,
// We need to set minimal one default value, or use customUpdate to skip api call.
if len(input.Attributes) == 0 {
input.Attributes = map[string]*string{
"DelaySeconds": latest.ko.Spec.DelaySeconds,
}
}