chore!: remove memsize
#155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2025
darioush
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
memsizeblocks usage of Go 1.23. We'll be building with 1.23 viaavalanchegoanyway (which doesn't transitively importmemsize) so we want to run tests with the correct version. It will also unblock #154.How this works
✂️
We already cherry-pick the upstream commit (e467577) that removes
memsizewhen on release branches so we instead do it ourselves and no longer cherry-pick. To avoid conflicts at the nextgethsync, this PR should be reverted before performing the merge. See #128.How this was tested
Existing tests.