Skip to content

Tracker: commits to revert before next upstream sync #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ARR4N opened this issue Feb 11, 2025 · 0 comments
Open

Tracker: commits to revert before next upstream sync #128

ARR4N opened this issue Feb 11, 2025 · 0 comments
Assignees
@ARR4N
Labels
Category: Code quality ✏️ Priority: ⛓️ With next Geth sync Has to be done before the next release

Comments

@ARR4N
Copy link
Collaborator

ARR4N commented Feb 11, 2025 •
edited
Loading

PRs introducing changes also performed later in geth. Reverting their commits before merging the upstream branch will avoid conflicts.

  1. refactor!(core/types): Block method WithBody(Body) signature #110
  2. chore!: remove memsize #155
@ARR4N ARR4N self-assigned this Feb 11, 2025
@ARR4N ARR4N added the Priority: ⛓️ With next Geth sync Has to be done before the next release label Feb 11, 2025
This was referenced Feb 25, 2025
Merged
Merged
ARR4N added a commit that referenced this issue Feb 25, 2025
@ARR4N
chore!: remove memsize (#155)
24d7bde 
## Why this should be merged

`memsize` blocks usage of Go 1.23. We'll be building with 1.23 via
`avalanchego` anyway (which doesn't transitively import `memsize`) so we
want to run tests with the correct version. It will also unblock #154.

## How this works

✂️ 

We already cherry-pick the upstream commit
(e467577) that removes `memsize` when
on release branches so we instead do it ourselves and no longer
cherry-pick. To avoid conflicts at the next `geth` sync, this PR should
be reverted before performing the merge. See #128.

## How this was tested

Existing tests.
@ARR4N ARR4N mentioned this issue May 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ARR4N ARR4N

Labels
Category: Code quality ✏️ Priority: ⛓️ With next Geth sync Has to be done before the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ARR4N