Skip to content

core/types: pin code generators versions when alias types are supported #833

@qdm12

Description

@qdm12

We use two code generators to generate codec functions for JSON and RLP codecs:

  1. github.com/fjl/gencodec for JSON - done in chore(ci): check gencodec generated files are up to date #856
  2. github.com/ava-labs/libevm/rlp/rlpgen for RLP (code forked from geth)

The support for type aliases is ongoing as follows:

  1. support alias types for Go >= 1.23 fjl/gencodec#25
  2. feat(rlp/rlpgen): support alias types libevm#154
  3. fix: support imported aliased types fjl/gencodec#27

Once these are done, we should:

  1. Upgrade libevm to the version containing this new feature
  2. (done) Pin fjl/gencodec version to the version containing this new feature, using tools.go + go mod tidy
  3. (half-done) Add a CI check to ensure these generated files are kept in sync (similar to how it is done with mockgen)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions