Skip to content

Commit e467577

Browse files
authored
internal/debug: remove memsize (ethereum#30253)
Removing because memsize will very likely be broken by Go 1.23. See fjl/memsize#4
1 parent 67b8137 commit e467577

File tree

4 files changed

+0
-9
lines changed

4 files changed

+0
-9
lines changed

cmd/geth/main.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,8 +360,6 @@ func geth(ctx *cli.Context) error {
360360
// it unlocks any requested accounts, and starts the RPC/IPC interfaces and the
361361
// miner.
362362
func startNode(ctx *cli.Context, stack *node.Node, isConsole bool) {
363-
debug.Memsize.Add("node", stack)
364-
365363
// Start up the node itself
366364
utils.StartNode(ctx, stack, isConsole)
367365

go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ require (
2626
github.com/fatih/color v1.16.0
2727
github.com/ferranbt/fastssz v0.1.2
2828
github.com/fjl/gencodec v0.0.0-20230517082657-f9840df7b83e
29-
github.com/fjl/memsize v0.0.2
3029
github.com/fsnotify/fsnotify v1.6.0
3130
github.com/gballet/go-libpcsclite v0.0.0-20190607065134-2772fd86a8ff
3231
github.com/gofrs/flock v0.8.1

go.sum

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,6 @@ github.com/ferranbt/fastssz v0.1.2 h1:Dky6dXlngF6Qjc+EfDipAkE83N5I5DE68bY6O0VLNP
178178
github.com/ferranbt/fastssz v0.1.2/go.mod h1:X5UPrE2u1UJjxHA8X54u04SBwdAQjG2sFtWs39YxyWs=
179179
github.com/fjl/gencodec v0.0.0-20230517082657-f9840df7b83e h1:bBLctRc7kr01YGvaDfgLbTwjFNW5jdp5y5rj8XXBHfY=
180180
github.com/fjl/gencodec v0.0.0-20230517082657-f9840df7b83e/go.mod h1:AzA8Lj6YtixmJWL+wkKoBGsLWy9gFrAzi4g+5bCKwpY=
181-
github.com/fjl/memsize v0.0.2 h1:27txuSD9or+NZlnOWdKUxeBzTAUkWCVh+4Gf2dWFOzA=
182-
github.com/fjl/memsize v0.0.2/go.mod h1:VvhXpOYNQvB+uIk2RvXzuaQtkQJzzIx6lSBe1xv7hi0=
183181
github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
184182
github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=
185183
github.com/fsnotify/fsnotify v1.6.0 h1:n+5WquG0fcWoWp6xPWfHdbskMCQaFnG6PfBrh1Ky4HY=

internal/debug/flags.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,12 @@ import (
3131
"github.com/ethereum/go-ethereum/log"
3232
"github.com/ethereum/go-ethereum/metrics"
3333
"github.com/ethereum/go-ethereum/metrics/exp"
34-
"github.com/fjl/memsize/memsizeui"
3534
"github.com/mattn/go-colorable"
3635
"github.com/mattn/go-isatty"
3736
"github.com/urfave/cli/v2"
3837
"gopkg.in/natefinch/lumberjack.v2"
3938
)
4039

41-
var Memsize memsizeui.Handler
42-
4340
var (
4441
verbosityFlag = &cli.IntFlag{
4542
Name: "verbosity",
@@ -313,7 +310,6 @@ func StartPProf(address string, withMetrics bool) {
313310
if withMetrics {
314311
exp.Exp(metrics.DefaultRegistry)
315312
}
316-
http.Handle("/memsize/", http.StripPrefix("/memsize", &Memsize))
317313
log.Info("Starting pprof server", "addr", fmt.Sprintf("http://%s/debug/pprof", address))
318314
go func() {
319315
if err := http.ListenAndServe(address, nil); err != nil {

0 commit comments

Comments
 (0)