Skip to content

ORC-1967: [C++] Fix Windows build #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
georgthegreat wants to merge 1 commit into from
Closed

ORC-1967: [C++] Fix Windows build #2345

georgthegreat wants to merge 1 commit into from

Conversation

@georgthegreat
Copy link
Contributor

@georgthegreat georgthegreat commented Jul 31, 2025 •
edited by wgtmac
Loading

@github-actions github-actions bot added the CPP label Jul 31, 2025
dongjoon-hyun
dongjoon-hyun reviewed Jul 31, 2025
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a PR, @georgthegreat .

Is this all we need to run on GitHub Action Windows 2025 environment?

@georgthegreat
Copy link
Contributor Author

georgthegreat commented Aug 1, 2025

I have succesfully build patched version in our internal environment, which uses clang-cl from llvm-18.

I am not sure which environment GitHub Action Windows 2025 corresponds to, so I am unable to say for sure.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 2, 2025

Previously, Apache ORC used Windows 2019-based GitHub Action job for test coverage until it reached the EOL.

We tried to migrate to Windows 2025-based GitHub Action job, but it's still failing until now.

If you want, you can include my PR (#2273) into this PR. Then, it will prove your PR fixes Windows build in the community, @georgthegreat . Or, you can update .github/workflows/build_and_test.yml until you make it passes.

@wgtmac wgtmac mentioned this pull request Aug 3, 2025
Closed
@georgthegreat
Copy link
Contributor Author

georgthegreat commented Aug 6, 2025

@dongjoon-hyun this PR was created via GitHub Web Interface, it is quite inconvenient to work with branches in it.
Maybe we can merge this PR and then try to merge / rebase your PR from master branch?

@wgtmac
Copy link
Member

wgtmac commented Aug 6, 2025

Agreed. Let's move forward.

@wgtmac wgtmac changed the title Fix Windows build ORC-1967: [C++] Fix Windows build Aug 6, 2025
@wgtmac wgtmac closed this in 2f7889e Aug 6, 2025
wgtmac pushed a commit that referenced this pull request Aug 6, 2025
@georgthegreat @wgtmac
ORC-1967: [C++] Fix Windows build
e3c0364 
See
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/byteswap-uint64-byteswap-ulong-byteswap-ushort?view=msvc-170

Closes #2345 from georgthegreat/patch-5.

Authored-by: Yuriy Chernyshov <[email protected]>
Signed-off-by: Gang Wu <[email protected]>
(cherry picked from commit 2f7889e)
Signed-off-by: Gang Wu <[email protected]>
@georgthegreat georgthegreat deleted the patch-5 branch August 6, 2025 20:08
@kou kou mentioned this pull request Aug 22, 2025
Merged
raulcd pushed a commit to apache/arrow that referenced this pull request Aug 25, 2025
@kou
GH-47399: [C++] Update bundled Apache ORC to 2.2.0 with Protobuf patch (
f16b6ac 
#47408)

### Rationale for this change

apache/orc#2357 is needed for recent Protobuf.

### What changes are included in this PR?

* Update bundled Apache ORC to 2.2.0.
  *  apache/orc#2345 is needed for MSVC.
* Apply apache/orc#2357 because it's not released yet.
* Enable `CMP0077` for bundled dependencies by default to avoid `set(CACHE)`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #47399

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
gitmodimo pushed a commit to gitmodimo/arrow that referenced this pull request Oct 2, 2025
@kou
apacheGH-47399: [C++] Update bundled Apache ORC to 2.2.0 with Protobu…
980fd2d 
…f patch (apache#47408)

### Rationale for this change

apache/orc#2357 is needed for recent Protobuf.

### What changes are included in this PR?

* Update bundled Apache ORC to 2.2.0.
  *  apache/orc#2345 is needed for MSVC.
* Apply apache/orc#2357 because it's not released yet.
* Enable `CMP0077` for bundled dependencies by default to avoid `set(CACHE)`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#47399

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun left review comments

Assignees

No one assigned

Labels

CPP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@georgthegreat @dongjoon-hyun @wgtmac