GH-47399: [C++] Update bundled Apache ORC to 2.2.0 with Protobuf patch #47408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
kou
force-pushed
the
cpp-orc-protobuf-int64
branch
from
33fb77c to
b020465
Compare
Member
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: b020465759058b027d7b43c4c9a85d7fac664105 Submitted crossbow builds: ursacomputing/crossbow @ actions-4e62e91a40
|
kou
force-pushed
the
cpp-orc-protobuf-int64
branch
2 times, most recently
from
290cc09 to
528eb47
Compare
kou
force-pushed
the
cpp-orc-protobuf-int64
branch
from
528eb47 to
9b15c2d
Compare
wgtmac
reviewed
Aug 25, 2025
| list(APPEND ORC_PATCHES ${CMAKE_CURRENT_LIST_DIR}/orc-2357.patch) | ||
| endif() | ||
| if(ORC_PATCHES) | ||
| find_program(PATCH patch REQUIRED) |
Member
There was a problem hiding this comment.
I recall that there are some docker images required to add patch dependency when I was fixing a previous ORC build failure. Is it still the case?
Member
Author
There was a problem hiding this comment.
Based on the CI result, we don't need to add additional patch dependency. But let's try R and wheel related CI jobs before we merge this.
Member
There was a problem hiding this comment.
None of the CI failures are related and are currently failing on the nightlies.
wgtmac
reviewed
Aug 25, 2025
wgtmac
approved these changes
Aug 25, 2025
Member
Author
|
@github-actions crossbow submit -g wheel -g r |
github-actions
bot
added
awaiting changes
|
Revision: 9b15c2d Submitted crossbow builds: ursacomputing/crossbow @ actions-59686f3dfc
|
raulcd
approved these changes
Aug 25, 2025
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
👍 we can merge this to fix CI on PRs.
The CI failures are unrelated.
| list(APPEND ORC_PATCHES ${CMAKE_CURRENT_LIST_DIR}/orc-2357.patch) | ||
| endif() | ||
| if(ORC_PATCHES) | ||
| find_program(PATCH patch REQUIRED) |
Member
There was a problem hiding this comment.
None of the CI failures are related and are currently failing on the nightlies.
github-actions
bot
added
awaiting review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f16b6ac. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
gitmodimo
pushed a commit
to gitmodimo/arrow
that referenced
this pull request
Oct 2, 2025
…f patch (apache#47408) ### Rationale for this change apache/orc#2357 is needed for recent Protobuf. ### What changes are included in this PR? * Update bundled Apache ORC to 2.2.0. * apache/orc#2345 is needed for MSVC. * Apply apache/orc#2357 because it's not released yet. * Enable `CMP0077` for bundled dependencies by default to avoid `set(CACHE)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#47399 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
apache/orc#2357 is needed for recent Protobuf.
What changes are included in this PR?
int64_tinstead ofgoogle::protobuf::int64forProtobufv22+ orc#2357 because it's not released yet.CMP0077for bundled dependencies by default to avoidset(CACHE).Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.