ORC-1924: Add Windows 2025 GitHub Action job
#2273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Windows 2025 GitHub Action jobWindows 2025 GitHub Action job
Member
Author
|
Just for the record, |
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 17, 2025
### What changes were proposed in this pull request? This PR aims to remove `Windows 2019` GitHub Action job. Note that ORC-1924 is created in order to recover Windows test coverage later. - #2273 ### Why are the changes needed? `Windows 2019` is deprecated already and will be removed soon. - actions/runner-images#12045 ### How was this patch tested? Manual review because this is a removal of CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2274 from dongjoon-hyun/ORC-1923. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 17, 2025
### What changes were proposed in this pull request? This PR aims to remove `Windows 2019` GitHub Action job. Note that ORC-1924 is created in order to recover Windows test coverage later. - #2273 ### Why are the changes needed? `Windows 2019` is deprecated already and will be removed soon. - actions/runner-images#12045 ### How was this patch tested? Manual review because this is a removal of CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2274 from dongjoon-hyun/ORC-1923. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7e452b9) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 17, 2025
This PR aims to remove `Windows 2019` GitHub Action job. Note that ORC-1924 is created in order to recover Windows test coverage later. - #2273 `Windows 2019` is deprecated already and will be removed soon. - actions/runner-images#12045 Manual review because this is a removal of CI. No. Closes #2274 from dongjoon-hyun/ORC-1923. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7e452b9) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 17, 2025
This PR aims to remove `Windows 2019` GitHub Action job. Note that ORC-1924 is created in order to recover Windows test coverage later. - #2273 `Windows 2019` is deprecated already and will be removed soon. - actions/runner-images#12045 Manual review because this is a removal of CI. No. Closes #2274 from dongjoon-hyun/ORC-1923. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7e452b9) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 17, 2025
This PR aims to remove `Windows 2019` GitHub Action job. Note that ORC-1924 is created in order to recover Windows test coverage later. - #2273 `Windows 2019` is deprecated already and will be removed soon. - actions/runner-images#12045 Manual review because this is a removal of CI. No. Closes #2274 from dongjoon-hyun/ORC-1923. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7e452b9) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Oh, you can take over this, @wgtmac . Let me close mine. |
Member
Author
|
Thank you so much, @wgtmac . |
Member
|
Sure, let me try it on my own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?