Skip to content

ORC-1924: Add Windows 2025 GitHub Action job #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 4 commits into from
Closed

ORC-1924: Add Windows 2025 GitHub Action job #2273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
488053f
Test Windows 2025
dongjoon-hyun Jun 17, 2025
f0175cc
Visual Studio 17 2022
dongjoon-hyun Jun 17, 2025
6971241
Use release build
dongjoon-hyun Jun 17, 2025
16ee0bd
modify c++ file to trigger ci
wgtmac Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,37 @@ jobs:
run: |
cat /home/runner/work/orc/orc/build/java/rat.txt

windows:
name: "C++ ${{ matrix.simd }} Test on Windows"
runs-on: windows-2025
strategy:
fail-fast: false
matrix:
simd:
- General
- AVX512
env:
ORC_USER_SIMD_LEVEL: AVX512
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Add msbuild to PATH
uses: microsoft/[email protected]
with:
msbuild-architecture: x64
- name: "Test"
shell: bash
run: |
mkdir build
cd build
if [ "${{ matrix.simd }}" = "General" ]; then
cmake .. -G "Visual Studio 17 2022" -DCMAKE_BUILD_TYPE=RELEASE -DBUILD_LIBHDFSPP=OFF -DBUILD_TOOLS=OFF -DBUILD_JAVA=OFF
else
cmake .. -G "Visual Studio 17 2022" -DCMAKE_BUILD_TYPE=RELEASE -DBUILD_LIBHDFSPP=OFF -DBUILD_TOOLS=OFF -DBUILD_JAVA=OFF -DBUILD_ENABLE_AVX512=ON
fi
cmake --build . --config Debug
ctest -C Debug --output-on-failure

simdUbuntu:
name: "SIMD programming using C++ intrinsic functions on ${{ matrix.os }}"
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 0 additions & 2 deletions c++/include/orc/BloomFilter.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
#ifndef ORC_BLOOMFILTER_HH
#define ORC_BLOOMFILTER_HH

#include "orc/orc-config.hh"

#include <memory>
#include <vector>

Expand Down