YARN-11424. [Federation] Router Supports DeregisterSubCluster. #5363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@goiri Can you help review this PR? Thank you very much! |
goiri
approved these changes
Feb 7, 2023
| /** Subcluster timeout allowed by Router. **/ | ||
| public static final String ROUTER_SUBCLUSTER_EXPIRATION_TIME = | ||
| ROUTER_PREFIX + "subcluster.heartbeat.expiration.time"; | ||
| public static final long DEFAULT_ROUTER_SUBCLUSTER_EXPIRATION_TIME = 1800000; |
Contributor
Author
There was a problem hiding this comment.
Thank you very much for helping to review the code, I will modify the code.
| return; | ||
| } | ||
| if (usageInfo.args == null) { | ||
| builder.append("Usage: routeradmin [" + cmd + "]\n"); |
Member
There was a problem hiding this comment.
If we have a StringBuilder, use append not +
Contributor
Author
There was a problem hiding this comment.
I will modify the code.
| } | ||
|
|
||
| public boolean isUsable() { | ||
| return !isUnusable(); |
Member
There was a problem hiding this comment.
Let's remove isUnusable() and always use isUsable with ! and so on.
Negative methods are usually not recommended.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Can you help review this pr again? Thank you very much! |
goiri
approved these changes
Mar 14, 2023
...hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
Outdated
Show resolved
Hide resolved
|
|
||
| private DeregisterSubClusterResponse generateAllSubClusterData() { | ||
| List<DeregisterSubClusters> deregisterSubClusterList = new ArrayList<>(); | ||
| for (int i = 1; i <= 4; i++) { |
Contributor
Author
There was a problem hiding this comment.
I will modify the code.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Can you help to merge this pr into the trunk branch? Thank you very much! I will continue to improve |
Member
|
Can we get a clean build? |
Contributor
Author
I will retrigger Jenkins. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Thank you very much for your help in reviewing the code! The javac compilation error is because we have changed the proto file. This part of the warning seems unavoidable. DeregisterSubClustersProto |
Member
No way we can get a clean build then? |
Contributor
Author
|
@goiri This pr may not be able to clean bulid, I read this part of the code carefully. The javac warning should be caused by a new proto code added to this pr. This code will be directly compiled into We can check the following issue, the current version of protobuf does not seem to be able to solve it. In the complete compilation results of the We can see the link below: |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
slfan1989
force-pushed
the
YARN-11424-V2
branch
from
2113f77 to
c84c007
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Can you help to merge this pr into the trunk branch? Thank you very much! I will continue to follow up YARN-11483. |
Contributor
Author
|
@goiri Thank you very much for helping to review the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11424. [Federation] Router Supports DeregisterSubCluster.
In YARN Federation mode, if we want to execute SubCluster commands, we need to go to SubCluster RM and execute commands.Router Should Provide Cli commands, So that We Can Execute Commands For Different SubClusters.
Router provides commands for Deregister SubCluster.